AshharAhmadKhan commented on PR #5590: URL: https://github.com/apache/fineract/pull/5590#issuecomment-4024220297
@adamsaghy @IOhacker The failing `test-core-5` checks have been fixed. Root cause: After undoing an interest transaction, the DB column `total_interest_posted_derived` becomes `0`. The `DepositAccountReadPlatformServiceImpl` intentionally uses `getBigDecimalDefaultToNullIfZero` for all summary fields, which converts `0` to `null` — this is consistent behaviour across the entire deposit reader. The test was calling `.floatValue()` directly on a potentially null `Float`, causing an NPE. Fix: Added a null check in the test assertion so that a null `totalInterestPosted` (which semantically means zero) is treated as `0f`, which is the correct expected value after an undo. The service implementation, routing fix, and journal entry logic are all unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
