adamsaghy commented on code in PR #5580: URL: https://github.com/apache/fineract/pull/5580#discussion_r2910595582
########## fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloanproduct/calc/ProjectedAmortizationScheduleModel.java: ########## Review Comment: You should build safe guards to avoid incorrect balance calculation: - Net amortization calculation balance cannot be higher than "origination fee / discount amount" - Aggregated "expected amortiztion balance" cannot be higher than "origination fee / discount amount" - Aggregated "Actual total amortization" cannot be higher than "origination fee / discount amount" - Original forecast balance cannot be negative - Running NPV value cannot be negative - Running discount factor cannot be negative or 0 - Expected payment cannot be negative -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
