This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit ab98ae8da1c8473dfd7841e5bdee499a1d0826f0
Merge: 13d4f1ea25 81a3809370
Author: Adam Saghy <[email protected]>
AuthorDate: Thu Apr 2 15:09:05 2026 +0000

    Merge pull request #5715
    
    FINERACT-2568: Remove unnecessary @Consumes annotations from GET and DELETE 
endpoints

 .../accounting/closure/api/GLClosuresApiResource.java     |  3 ---
 .../api/FinancialActivityAccountsApiResource.java         |  4 ----
 .../accounting/glaccount/api/GLAccountsApiResource.java   |  4 ----
 .../provisioning/api/ProvisioningEntriesApiResource.java  |  3 ---
 .../accounting/rule/api/AccountingRuleApiResource.java    |  4 ----
 .../organisation/teller/api/CashierApiResource.java       |  2 --
 .../organisation/teller/api/TellerApiResource.java        | 13 -------------
 .../organisation/teller/api/TellerJournalApiResource.java |  2 --
 .../fineract/portfolio/charge/api/ChargesApiResource.java |  3 ---
 .../businessdate/api/BusinessDateApiResource.java         |  2 --
 .../infrastructure/cache/api/CacheApiResource.java        |  2 +-
 .../api/ExternalEventConfigurationApiResource.java        |  1 -
 .../external/api/InternalExternalEventsApiResource.java   |  3 ---
 .../organisation/monetary/api/CurrenciesApiResource.java  |  1 -
 .../portfolio/paymenttype/api/PaymentTypeApiResource.java |  3 ---
 .../documentmanagement/api/DocumentApiResource.java       |  3 ---
 .../documentmanagement/api/ImagesApiResource.java         |  1 -
 ...xternalAssetOwnerLoanProductAttributesApiResource.java |  1 -
 .../loanorigination/api/LoanOriginatorApiResource.java    |  6 ------
 .../loanorigination/api/LoanOriginatorsApiResource.java   |  6 ------
 .../portfolio/delinquency/api/DelinquencyApiResource.java |  7 -------
 .../rescheduleloan/api/RescheduleLoansApiResource.java    |  3 ---
 .../loanproduct/api/LoanProductsDetailsApiResource.java   |  2 --
 .../apache/fineract/mix/api/MixTaxonomyApiResource.java   |  2 --
 .../fineract/mix/api/MixTaxonomyMappingApiResource.java   |  1 -
 .../loanaccount/api/LoanBuyDownFeeApiResource.java        |  7 -------
 .../loanaccount/api/LoanCapitalizedIncomeApiResource.java |  9 ---------
 .../journalentry/api/JournalEntriesApiResource.java       |  4 ----
 .../apache/fineract/adhocquery/api/AdHocApiResource.java  |  4 ----
 .../cob/api/ConfigureBusinessStepApiResource.java         |  2 --
 .../apache/fineract/cob/api/InternalCOBApiResource.java   |  1 -
 .../fineract/cob/api/LoanAccountLockApiResource.java      |  2 --
 .../fineract/cob/api/LoanCOBCatchUpApiResource.java       |  2 --
 .../cob/api/WorkingCapitalLoanCOBCatchUpApiResource.java  |  2 --
 .../apache/fineract/commands/api/AuditsApiResource.java   |  4 ----
 .../fineract/commands/api/MakercheckersApiResource.java   |  3 ---
 .../api/AccountNumberFormatsApiResource.java              |  4 ----
 .../bulkimport/api/BulkImportApiResource.java             |  2 --
 .../campaigns/email/api/EmailApiResource.java             |  3 ++-
 .../campaigns/email/api/EmailCampaignApiResource.java     |  1 -
 .../email/api/EmailConfigurationApiResource.java          |  2 +-
 .../infrastructure/codes/api/CodeValuesApiResource.java   |  6 ------
 .../infrastructure/codes/api/CodesApiResource.java        |  4 ----
 .../api/ExternalServicesConfigurationApiResource.java     |  1 -
 .../configuration/api/GlobalConfigurationApiResource.java |  3 ---
 .../api/CreditBureauConfigurationApiResource.java         |  6 ------
 .../api/CreditBureauIntegrationApiResource.java           |  1 -
 .../dataqueries/api/DatatablesApiResource.java            |  6 ------
 .../dataqueries/api/EntityDatatableChecksApiResource.java |  2 --
 .../dataqueries/api/ReportsApiResource.java               |  4 ----
 .../dataqueries/api/RunreportsApiResource.java            |  3 ---
 .../entityaccess/api/FineractEntityApiResource.java       |  5 -----
 .../infrastructure/hooks/api/HookApiResource.java         |  3 ++-
 .../infrastructure/jobs/api/SchedulerApiResource.java     |  1 -
 .../infrastructure/jobs/api/SchedulerJobApiResource.java  |  5 ++++-
 .../reportmailingjob/api/ReportMailingJobApiResource.java |  3 ---
 .../api/ReportMailingJobRunHistoryApiResource.java        |  2 --
 .../fineract/infrastructure/sms/api/SmsApiResource.java   |  3 ++-
 .../infrastructure/survey/api/LikelihoodApiResource.java  |  2 --
 .../infrastructure/survey/api/PovertyLineApiResource.java |  3 ---
 .../infrastructure/survey/api/SurveyApiResource.java      |  5 -----
 .../fineract/interoperation/api/InteropApiResource.java   | 12 ------------
 .../notification/api/NotificationApiResource.java         |  1 -
 .../organisation/holiday/api/HolidaysApiResource.java     |  4 ----
 .../office/api/OfficeTransactionsApiResource.java         |  3 ---
 .../organisation/office/api/OfficesApiResource.java       |  4 ----
 .../provisioning/api/ProvisioningCategoryApiResource.java |  2 --
 .../provisioning/api/ProvisioningCriteriaApiResource.java |  4 ----
 .../fineract/organisation/staff/api/StaffApiResource.java |  3 ++-
 .../workingdays/api/WorkingDaysApiResource.java           |  2 --
 .../account/api/AccountTransfersApiResource.java          |  4 ----
 .../account/api/StandingInstructionApiResource.java       |  3 ---
 .../api/StandingInstructionHistoryApiResource.java        |  2 --
 .../portfolio/accounts/api/AccountsApiResource.java       |  3 ---
 .../address/api/EntityFieldConfigurationApiResource.java  |  2 --
 .../portfolio/calendar/api/CalendarsApiResource.java      |  4 ----
 .../portfolio/client/api/ClientAddressApiResource.java    |  2 --
 .../portfolio/client/api/ClientChargesApiResource.java    |  4 ----
 .../client/api/ClientFamilyMembersApiResource.java        |  4 ----
 .../client/api/ClientIdentifiersApiResource.java          |  4 ----
 .../client/api/ClientTransactionsApiResource.java         |  6 ------
 .../fineract/portfolio/client/api/ClientsApiResource.java |  6 ------
 .../client/api/InternalClientInformationApiResource.java  |  2 --
 .../portfolio/collateral/api/CollateralsApiResource.java  |  4 ----
 .../api/ClientCollateralManagementApiResource.java        |  4 ----
 .../api/CollateralManagementApiResource.java              |  4 ----
 .../api/LoanCollateralManagementApiResource.java          |  3 ---
 .../fineract/portfolio/fund/api/FundsApiResource.java     |  2 --
 .../fineract/portfolio/group/api/CentersApiResource.java  |  5 -----
 .../fineract/portfolio/group/api/GroupsApiResource.java   |  7 -------
 .../portfolio/group/api/GroupsLevelApiResource.java       |  2 --
 .../api/InterestRateChartSlabsApiResource.java            |  3 ++-
 .../api/InterestRateChartsApiResource.java                |  3 ++-
 .../portfolio/loanaccount/api/BulkLoansApiResource.java   |  1 -
 .../api/InternalLoanInformationApiResource.java           |  5 -----
 .../portfolio/loanaccount/api/LoanChargesApiResource.java | 12 ------------
 .../api/LoanDisbursementDetailApiResource.java            |  1 -
 .../loanaccount/api/LoanTransactionsApiResource.java      |  8 --------
 .../portfolio/loanaccount/api/LoansApiResource.java       | 15 ---------------
 .../api/pointintime/LoansPointInTimeApiResource.java      |  2 --
 .../loanaccount/guarantor/api/GuarantorsApiResource.java  |  5 -----
 .../loanproduct/api/LoanProductsApiResource.java          |  4 ----
 .../loanproduct/productmix/api/ProductMixApiResource.java |  2 --
 .../portfolio/meeting/api/MeetingsApiResource.java        |  3 ++-
 .../fineract/portfolio/note/api/NotesApiResource.java     |  3 ++-
 .../portfolio/products/api/ProductsApiResource.java       |  3 ---
 .../fineract/portfolio/rate/api/RateApiResource.java      |  2 --
 .../api/RepaymentWithPostDatedChecksApiResource.java      |  3 ---
 .../DepositAccountOnHoldFundTransactionsApiResource.java  |  2 --
 .../api/FixedDepositAccountTransactionsApiResource.java   |  2 --
 .../savings/api/FixedDepositAccountsApiResource.java      |  6 ------
 .../savings/api/FixedDepositProductsApiResource.java      |  4 ----
 .../api/InternalSavingsAccountInformationApiResource.java |  2 --
 .../RecurringDepositAccountTransactionsApiResource.java   |  2 --
 .../savings/api/RecurringDepositAccountsApiResource.java  |  5 -----
 .../savings/api/RecurringDepositProductsApiResource.java  |  4 ----
 .../savings/api/SavingsAccountChargesApiResource.java     |  4 ----
 .../api/SavingsAccountTransactionsApiResource.java        |  2 --
 .../portfolio/savings/api/SavingsAccountsApiResource.java |  6 ------
 .../portfolio/savings/api/SavingsProductsApiResource.java |  4 ----
 .../fineract/portfolio/search/api/SearchApiResource.java  |  2 +-
 .../shareproducts/api/ShareDividendApiResource.java       |  3 ---
 .../apache/fineract/spm/api/LookupTableApiResource.java   |  2 --
 .../org/apache/fineract/spm/api/ScorecardApiResource.java |  3 ---
 .../java/org/apache/fineract/spm/api/SpmApiResource.java  |  2 --
 .../fineract/template/api/TemplatesApiResource.java       |  4 +++-
 .../api/PasswordPreferencesApiResource.java               |  2 --
 .../useradministration/api/PermissionsApiResource.java    |  1 -
 .../fineract/useradministration/api/RolesApiResource.java |  4 ----
 .../fineract/useradministration/api/UsersApiResource.java |  4 ----
 .../floatingrates/api/FloatingRatesApiResource.java       |  2 --
 .../security/api/TwoFactorConfigurationApiResource.java   |  2 +-
 .../portfolio/tax/api/TaxComponentApiResource.java        |  3 ---
 .../fineract/portfolio/tax/api/TaxGroupApiResource.java   |  3 ---
 ...WorkingCapitalLoanAmortizationScheduleApiResource.java |  2 --
 .../api/WorkingCapitalLoanApiResource.java                |  6 ------
 .../api/WorkingCapitalLoanTransactionsApiResource.java    |  8 --------
 .../api/WorkingCapitalLoanProductApiResource.java         |  6 ------
 138 files changed, 27 insertions(+), 464 deletions(-)

diff --cc 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountTransactionsApiResource.java
index 097d692981,298a43d65a..32d7cbf93a
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountTransactionsApiResource.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountTransactionsApiResource.java
@@@ -103,23 -96,8 +102,22 @@@ public class FixedDepositAccountTransac
                  
SavingsApiSetConstants.SAVINGS_TRANSACTION_RESPONSE_DATA_PARAMETERS);
      }
  
 +    @GET
 +    @Consumes({ MediaType.APPLICATION_JSON })
 +    @Produces({ MediaType.APPLICATION_JSON })
 +    @Operation(summary = "List fixed deposit account transactions", 
operationId = "retrieveAllFixedDepositAccountTransactions")
 +    @ApiResponses({
 +            @ApiResponse(responseCode = "200", description = "OK", content = 
@Content(array = @ArraySchema(schema = @Schema(implementation = 
FixedDepositAccountTransactionsApiResourceSwagger.GetFixedDepositAccountsAccountIdTransactionsResponse.class))))
 })
 +    public String retrieveAll(@PathParam("fixedDepositAccountId") final Long 
fixedDepositAccountId, @Context final UriInfo uriInfo) {
 +        
this.context.authenticatedUser().validateHasReadPermission(DepositsApiConstants.FIXED_DEPOSIT_ACCOUNT_RESOURCE_NAME);
 +        final Collection<SavingsAccountTransactionData> transactions = 
this.savingsAccountReadPlatformService
 +                .retrieveAllTransactions(fixedDepositAccountId, 
DepositAccountType.FIXED_DEPOSIT);
 +        final ApiRequestJsonSerializationSettings settings = 
this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());
 +        return this.toApiJsonSerializer.serialize(settings, transactions, 
FIXED_DEPOSIT_TRANSACTION_RESPONSE_DATA_PARAMETERS);
 +    }
 +
      @GET
      @Path("{transactionId}")
-     @Consumes({ MediaType.APPLICATION_JSON })
      @Produces({ MediaType.APPLICATION_JSON })
      @Operation(summary = "Retrieve a fixed deposit account transaction", 
operationId = "retrieveOneFixedDepositAccountTransaction")
      public String retrieveOne(@PathParam("fixedDepositAccountId") final Long 
fixedDepositAccountId,

Reply via email to