This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
from df11055691 Merge pull request #5337
add 096ef66d71 FINERACT-2515: Refactor InterestIncentiveAttributeName and
resolve TODOs
add 4f8a23c20b Merge pull request #5579
No new revisions were added by this update.
Summary of changes:
.../accountdetails/domain/AccountType.java | 4 --
.../portfolio/calendar/domain/Calendar.java | 6 +-
.../calendar/domain/CalendarFrequencyType.java | 4 --
.../calendar/domain/CalendarWeekDaysType.java | 4 --
.../calendar/service/CalendarEnumerations.java | 8 +--
.../portfolio/common/domain/ConditionType.java | 5 --
.../portfolio/common/domain/NthDayType.java | 4 --
.../common/domain/PeriodFrequencyType.java | 10 ---
.../common/service/CommonEnumerations.java | 2 +-
.../savings/DepositAccountOnClosureType.java | 35 +---------
.../portfolio/savings/DepositAccountType.java | 25 --------
.../savings/PreClosurePenalInterestOnType.java | 15 -----
.../portfolio/savings/RecurringDepositType.java | 5 --
.../savings/SavingsAccountTransactionType.java | 4 --
.../savings/SavingsPeriodFrequencyType.java | 30 +++------
.../savings/service/SavingsEnumerations.java | 12 ++--
.../portfolio/loanaccount/domain/Loan.java | 2 +-
.../ExecuteReportMailingJobsTasklet.java | 4 +-
.../campaigns/sms/domain/SmsCampaign.java | 2 +-
.../ReportMailingJobEmailAttachmentFileFormat.java | 20 +-----
...ortMailingJobStretchyReportParamDateOption.java | 18 +-----
.../service/InterestIncentivesEnumerations.java | 6 +-
.../service/InterestRateChartEnumerations.java | 2 +-
.../serialization/LoanApplicationValidator.java | 4 +-
.../savings/data/DepositAccountDataValidator.java | 6 +-
.../DepositAccountTransactionDataValidator.java | 5 +-
.../savings/domain/DepositAccountAssembler.java | 8 +--
.../domain/DepositAccountDomainServiceJpa.java | 25 ++++----
.../savings/domain/FixedDepositAccount.java | 4 +-
.../savings/domain/RecurringDepositAccount.java | 4 +-
...untPreMatureCalculationPlatformServiceImpl.java | 4 +-
.../DepositAccountReadPlatformServiceImpl.java | 24 +++----
...countWritePlatformServiceJpaRepositoryImpl.java | 4 +-
.../DepositProductReadPlatformServiceImpl.java | 8 +--
.../SavingsAccountInterestPostingServiceImpl.java | 5 +-
.../SavingsAccrualWritePlatformServiceImpl.java | 3 +-
...avingsAccountTransactionsSearchServiceImpl.java | 2 +-
.../shareproducts/SharePeriodFrequencyType.java | 5 --
.../domain/InterestRateChartSlabFields.java | 3 +-
.../incentive/InterestIncentiveAttributeName.java | 75 ++++++----------------
.../incentive/InterestIncentiveEntityType.java | 27 ++------
.../incentive/InterestIncentiveType.java | 36 +++--------
.../domain/DepositAccountTermAndPreClosure.java | 6 +-
.../portfolio/savings/domain/SavingsAccount.java | 2 +-
.../InterestIncentiveAttributeNameTest.java | 53 +++++++++++++++
45 files changed, 190 insertions(+), 350 deletions(-)
create mode 100644
fineract-savings/src/test/java/org/apache/fineract/portfolio/interestratechart/incentive/InterestIncentiveAttributeNameTest.java
