This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit b0d44657665f4e00c938bf541d8810e32120fe66
Merge: 6d2dc0be74 fb45b63196
Author: Adam Saghy <[email protected]>
AuthorDate: Mon Jun 8 16:03:44 2026 +0100

    Merge pull request #5914
    
    FINERACT-2165: Migrate BusinessDateHelper, LoanAccountLockHelper and 
ProductMixHelper to fineract-client-feign

 .../integrationtests/BaseLoanIntegrationTest.java  |  6 +--
 .../fineract/integrationtests/BatchApiTest.java    |  6 +--
 .../ClientSavingsIntegrationTest.java              | 39 ++++++++-------
 .../DelinquencyAndChargebackIntegrationTest.java   | 22 ++++-----
 .../DelinquencyBucketsIntegrationTest.java         | 30 ++++++------
 .../integrationtests/FixedDepositTest.java         |  4 +-
 .../FloatingRateInterestRecalculationTest.java     |  6 +--
 ...oanAccountArrearsAgeingCOBBusinessStepTest.java |  2 +-
 .../LoanAccountBackdatedDisbursementTest.java      | 28 +++++------
 .../LoanAccountOverpaidDateStatusTest.java         |  2 +-
 ...nWithOverlappingDownPaymentInstallmentTest.java | 16 +++----
 .../LoanAccountRepaymentCalculationTest.java       |  8 ++--
 ...ccrualTransactionOnChargeSubmittedDateTest.java | 41 ++++++++--------
 .../LoanAccrualTransactionReversalTest.java        |  2 +-
 .../LoanCOBAccountLockCatchupInlineCOBTest.java    | 49 +++++++++----------
 .../LoanCOBCatchUpInstanceModeIntegrationTest.java |  2 +-
 .../LoanCatchUpIntegrationTest.java                | 10 ++--
 .../LoanChargeOffAccountingTest.java               | 12 ++---
 .../LoanChargeSpecificDueDateTest.java             | 22 ++++-----
 ...rHandlingWithAdvancedPaymentAllocationTest.java |  2 +-
 ...nMultipleDisbursementRepaymentScheduleTest.java |  8 ++--
 ...ProductRepaymentStartDateConfigurationTest.java | 12 ++---
 .../LoanRepaymentScheduleWithDownPaymentTest.java  | 14 +++---
 .../LoanTransactionChargebackTest.java             | 10 ++--
 ...nReprocessForAdvancedPaymentAllocationTest.java |  2 +-
 .../ProductMixIntegrationTest.java                 |  9 ++--
 .../RepaymentReverseExternalIdTest.java            |  2 +-
 .../SavingsAccountTransactionTest.java             |  2 +-
 ...gsAccountTransactionsSearchIntegrationTest.java |  2 +-
 .../SavingsInterestPostingIntegrationTest.java     |  2 +-
 .../SavingsInterestPostingJobIntegrationTest.java  |  6 +--
 .../integrationtests/SchedulerJobsTestResults.java | 26 +++++-----
 ...ndoRepaymentWithDownPaymentIntegrationTest.java |  6 +--
 .../integrationtests/cob/CobPartitioningTest.java  |  4 +-
 .../common/BusinessDateHelper.java                 | 55 ++++------------------
 .../integrationtests/common/ProductMixHelper.java  | 51 +++++---------------
 .../common/SchedulerJobHelper.java                 |  2 +-
 .../common/loans/LoanAccountLockHelper.java        | 44 ++++-------------
 .../datatable/DatatableAdvancedQueryTest.java      |  4 +-
 .../inlinecob/InlineLoanCOBTest.java               | 44 ++++++++---------
 .../ExternalAssetOwnerTransferCancelTest.java      |  4 +-
 .../ExternalAssetOwnerTransferTest.java            |  6 +--
 .../InitiateExternalAssetOwnerTransferTest.java    |  6 +--
 43 files changed, 260 insertions(+), 370 deletions(-)

diff --cc 
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeOffAccountingTest.java
index 12d67e969b,27e30edea2..0f1a2c20b8
--- 
a/integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeOffAccountingTest.java
+++ 
b/integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeOffAccountingTest.java
@@@ -782,9 -784,9 +782,9 @@@ public class LoanChargeOffAccountingTes
              
assertTrue(loanDetails.getTransactions().get(3).getType().getChargeoff());
              assertEquals(4, loanDetails.getTransactions().size());
  
-             BusinessDateHelper.updateBusinessDate(requestSpec, responseSpec, 
BusinessDateType.BUSINESS_DATE, LocalDate.of(2020, 9, 8));
+             
BusinessDateHelper.updateBusinessDate(BusinessDateType.BUSINESS_DATE, 
LocalDate.of(2020, 9, 8));
              inlineLoanCOBHelper.executeInlineCOB(List.of(loanId.longValue()));
 -            
this.periodicAccrualAccountingHelper.runPeriodicAccrualAccounting(dateFormatter.format(LocalDate.of(2020,
 9, 8)));
 +            
PeriodicAccrualAccountingHelper.runPeriodicAccrualAccounting(dateFormatter.format(LocalDate.of(2020,
 9, 8)));
              loanDetails = 
loanTransactionHelper.getLoanDetails(loanId.longValue());
              
assertTrue(loanDetails.getTransactions().get(0).getType().getDisbursement());
              
assertTrue(loanDetails.getTransactions().get(1).getType().getAccrual());

Reply via email to