This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
from fc1f0fa Merge pull request #111 from edk12564/zizmor
add 844c3af - added missing CodeQL scans for Java/Typescript - removed
duplicated caching - added missing persist-credentials-false to tests
add dc7a1be - added github action to enforce prettier + eslint on the
frontend - created settings page on frontend for password resets and
openbanking consents - refactored account summary into scalable section cards -
refactored transfers to have dropdowns - transfers now comes from savings only
- transfers now targets own savings and beneficiaries savings only - savings ->
loan transfers moved to loan page - moved ABAC denial buttons onto the Demo
page - added frontend adapter str [...]
add 4286ae3 - handled CI issues - added demo store unit test
new fc8302a Merge pull request #109 from edk12564/github-actions-bugfixes
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/workflows/build-tests-backend.yml | 9 +-
.github/workflows/build-tests-frontend.yml | 9 +-
.github/workflows/codeql.yml | 4 +
.../{i18n-check.yml => prettier-eslint.yaml} | 19 +-
.gitignore | 1 +
consumer/compose.yaml | 2 +-
consumer/scripts/seed-demo.sh | 412 ++++-
consumer/scripts/seed-openbanking.sh | 433 +++++
.../api/AuditQueryController.java} | 43 +-
.../query/data/AuditEventListQuery.java} | 5 +-
.../query/data/AuditEventQueryData.java} | 13 +-
.../{command => query}/data/AuditEventSource.java | 2 +-
.../data/AuditEventType.java} | 30 +-
.../audit => audit/query}/data/AuditSeverity.java | 2 +-
.../audit/query/domain/AuditEventQueryEntity.java | 78 +
.../query/repository/AuditQueryRepository.java} | 21 +-
.../query/service/AuditQueryService.java} | 10 +-
.../audit/query/service/AuditQueryServiceImpl.java | 64 +
.../service/AuthenticationCommandServiceImpl.java | 12 +-
.../api/BeneficiariesCommandController.java | 2 -
.../command/data/BeneficiaryCommandData.java | 2 -
.../command/data/ConfirmAddBeneficiaryCommand.java | 1 -
.../data/ConfirmAddBeneficiaryCommandRequest.java | 4 -
.../data/InitiateAddBeneficiaryCommand.java | 1 -
.../data/InitiateAddBeneficiaryCommandRequest.java | 4 -
.../beneficiaries/command/domain/Beneficiary.java | 5 +-
...n.java => BeneficiarySelfAccountException.java} | 9 +-
.../service/BeneficiariesCommandServiceImpl.java | 67 +-
.../query/api/BeneficiariesQueryController.java | 7 -
.../query/data/BeneficiaryQueryData.java | 2 +-
.../query/service/BeneficiariesQueryService.java | 7 +-
.../service/BeneficiariesQueryServiceImpl.java | 20 +-
.../infrastructure/access/data/ActionPolicies.java | 2 +
.../infrastructure/access/data/ConsumerAction.java | 2 +
.../configs/OAuth2AuthorizationServerConfig.java | 38 +-
.../configs/OAuth2ConsumerProperties.java | 14 -
.../data/RegisteredTppStatus.java} | 8 +-
.../oauth2/domain/RegisteredTpp.java | 96 +
.../repository/RegisteredTppRepository.java} | 9 +-
.../oauth2/service/RegisteredTppClientAdapter.java | 109 ++
.../otp}/data/OtpConstants.java | 2 +-
.../otp}/data/OtpDestination.java | 2 +-
.../otp}/data/OtpMetadata.java | 2 +-
.../otp}/data/PendingOtp.java | 2 +-
.../otp}/exception/OtpDeliveryFailedException.java | 2 +-
.../exception/OtpDestinationInvalidException.java | 2 +-
.../otp}/exception/OtpTokenInvalidException.java | 2 +-
.../otp/repository/OtpRepository.java} | 6 +-
.../otp}/service/OtpEmailDeliveryService.java | 4 +-
.../otp/service/OtpService.java} | 8 +-
.../otp/service/OtpServiceImpl.java} | 28 +-
.../loans/query/api/LoansQueryController.java | 20 +-
.../query/data/LoanAccountListItemQueryData.java | 1 +
.../loans/query/data/LoanAccountQueryData.java | 1 +
.../loans/query/data/LoanTransactionListQuery.java | 3 +
...Data.java => LoanTransactionQueryResponse.java} | 10 +-
.../loans/query/service/LoansQueryService.java | 3 +-
.../loans/query/service/LoansQueryServiceImpl.java | 65 +-
.../query/data/OpenBankingAccountQueryData.java | 1 +
.../query/service/OpenBankingQueryServiceImpl.java | 2 +
.../service/RegistrationCommandServiceImpl.java | 12 +-
.../savings/query/api/SavingsQueryController.java | 7 +-
.../data/SavingsAccountListItemQueryData.java | 1 +
.../query/data/SavingsAccountQueryData.java | 2 +
.../savings/query/data/SavingsChargeQueryData.java | 1 +
.../query/data/SavingsTransactionQueryData.java | 1 +
...a.java => SavingsTransactionQueryResponse.java} | 10 +-
.../query/data/SavingsTransactionSearchQuery.java | 1 +
.../savings/query/service/SavingsQueryService.java | 3 +-
.../query/service/SavingsQueryServiceImpl.java | 56 +-
.../query/data/LoanSummaryItemQueryData.java | 1 +
.../query/data/SavingsSummaryItemQueryData.java | 1 +
.../query/service/SummaryQueryServiceImpl.java | 4 +-
.../service/TransfersCommandServiceImpl.java | 36 +-
.../query/api/TransfersQueryController.java | 67 +
.../query/data/TransferDirection.java} | 8 +-
.../query/data/TransferHistoryQuery.java} | 5 +-
.../query/data/TransferQueryData.java} | 11 +-
.../query/data/TransferQueryResponse.java} | 10 +-
.../TransferQueryAccessDeniedException.java} | 10 +-
...TransferQueryUpstreamUnavailableException.java} | 10 +-
.../query/service/TransfersQueryService.java} | 9 +-
.../query/service/TransfersQueryServiceImpl.java | 219 +++
.../command/service/UserCommandServiceImpl.java | 14 +-
consumer/src/main/resources/application.properties | 10 +-
.../db/changelog/db.changelog-master.yaml | 2 +
.../008-create-registered-tpps.yaml} | 47 +-
.../AuthenticationCommandServiceImplTest.java | 24 +-
.../BeneficiariesCommandServiceImplTest.java | 182 +-
.../service/BeneficiariesQueryServiceImplTest.java | 46 +-
.../cucumber/helpers/RegistrationHelper.java | 2 +-
.../consumer/cucumber/hooks/RegisteredTppSeed.java | 75 +
.../cucumber/steps/BeneficiariesSteps.java | 45 +-
.../consumer/cucumber/steps/RegistrationSteps.java | 4 +-
.../consumer/cucumber/steps/SavingsSteps.java | 31 +
.../consumer/cucumber/steps/TransfersSteps.java | 123 +-
.../OAuth2AuthorizationServerConfigTest.java | 66 -
.../service/RegisteredTppClientAdapterTest.java | 172 ++
.../otp/repository/OtpRepositoryTest.java} | 10 +-
.../otp/service/OtpServiceImplTest.java} | 78 +-
.../query/service/LoansQueryServiceImplTest.java | 160 +-
.../OpenBankingConsentCommandServiceImplTest.java | 1 -
.../service/OpenBankingQueryServiceImplTest.java | 4 +
.../query/service/SavingsQueryServiceImplTest.java | 178 +-
.../query/service/SummaryQueryServiceImplTest.java | 6 +-
.../service/TransfersCommandServiceImplTest.java | 232 ++-
.../service/TransfersQueryServiceImplTest.java | 383 ++++
.../service/UserCommandServiceImplTest.java | 28 +-
.../test/resources/features/beneficiaries.feature | 4 -
.../src/test/resources/features/savings.feature | 7 +
.../src/test/resources/features/transfers.feature | 23 +
frontend/.prettierignore | 1 +
frontend/angular.json | 22 +-
frontend/eslint.config.js | 48 +
frontend/package-lock.json | 1922 +++++++++++++++++++-
frontend/package.json | 10 +-
frontend/playwright/tests/loans.spec.ts | 170 +-
frontend/playwright/tests/transfers.spec.ts | 59 +-
frontend/public/i18n/en.json | 326 +++-
frontend/public/i18n/hi.json | 296 ++-
frontend/src/app/app.config.ts | 6 +-
frontend/src/app/app.routes.ts | 39 +-
frontend/src/app/app.ts | 2 +-
frontend/src/app/core/audit/audit-error-handler.ts | 7 +-
frontend/src/app/core/audit/audit.service.ts | 12 +-
frontend/src/app/core/auth/auth.service.ts | 4 +-
.../app/core/i18n/i18n.service.ts} | 46 +-
.../core/interceptors/error.interceptor.spec.ts | 67 +-
.../src/app/core/interceptors/error.interceptor.ts | 34 +-
.../notification.service.ts} | 34 +-
.../auth/forgot-password.component.spec.ts | 176 ++
.../app/features/auth/forgot-password.component.ts | 55 +-
frontend/src/app/features/auth/login.component.ts | 12 +-
.../beneficiaries/beneficiaries.component.spec.ts | 224 +++
.../beneficiaries/beneficiaries.component.ts | 251 ++-
.../beneficiaries/beneficiaries.store.spec.ts | 18 +-
.../features/beneficiaries/beneficiaries.store.ts | 18 +-
.../src/app/features/consent/consent.component.ts | 35 +-
frontend/src/app/features/demo/demo.component.ts | 188 ++
.../demo.store.spec.ts} | 50 +-
frontend/src/app/features/demo/demo.store.ts | 46 +
.../features/loans/loan-apply.component.spec.ts | 178 ++
.../src/app/features/loans/loan-apply.component.ts | 160 +-
.../features/loans/loan-repay.component.spec.ts | 234 +++
.../src/app/features/loans/loan-repay.component.ts | 334 ++++
.../app/features/loans/loans-detail.component.ts | 351 +++-
.../src/app/features/loans/loans-list.component.ts | 133 +-
.../features/loans/loans-transaction.component.ts | 16 +-
frontend/src/app/features/loans/loans.routes.ts | 12 +-
.../src/app/features/loans/loans.store.spec.ts | 58 +-
frontend/src/app/features/loans/loans.store.ts | 70 +-
.../src/app/features/profile/profile.component.ts | 299 +--
.../src/app/features/profile/profile.store.spec.ts | 98 +-
frontend/src/app/features/profile/profile.store.ts | 61 +-
.../registration/registration.component.spec.ts | 145 ++
.../registration/registration.component.ts | 57 +-
.../registration/registration.service.spec.ts | 4 +-
.../features/savings/savings-detail.component.ts | 214 ++-
.../app/features/savings/savings-list.component.ts | 74 +-
.../savings/savings-transaction.component.ts | 17 +-
.../src/app/features/savings/savings.routes.ts | 6 +-
.../src/app/features/savings/savings.store.spec.ts | 35 +-
frontend/src/app/features/savings/savings.store.ts | 33 +-
.../settings/change-password.component.spec.ts | 131 ++
.../change-password.component.ts | 46 +-
.../app/features/settings/settings.component.ts | 185 ++
.../settings.store.spec.ts} | 134 +-
.../settings.store.ts} | 111 +-
.../src/app/features/summary/summary.component.ts | 232 ++-
.../src/app/features/summary/summary.store.spec.ts | 54 +-
frontend/src/app/features/summary/summary.store.ts | 28 +-
.../transfers/transfer-form.component.spec.ts | 211 +++
...fer.component.ts => transfer-form.component.ts} | 176 +-
.../app/features/transfers/transfer.component.ts | 300 ++-
.../app/features/transfers/transfers.store.spec.ts | 59 +
.../src/app/features/transfers/transfers.store.ts | 36 +-
frontend/src/app/layout/shell.component.ts | 97 +-
frontend/src/app/shared/css/centered-page.scss | 5 +
frontend/src/app/shared/css/detail-page.scss | 6 +-
frontend/src/app/shared/css/filter-bar.scss | 6 +-
.../src/app/shared/css/{form.scss => pager.scss} | 14 +-
frontend/src/app/shared/css/table.scss | 21 +-
.../src/app/shared/language-switcher.component.ts | 33 +-
frontend/src/app/shared/models/account-types.ts | 23 -
frontend/src/app/shared/otp/otp.component.ts | 11 +-
.../src/app/shared/ui/status-badge.component.ts | 57 +-
.../utils/account-sort.ts} | 11 +-
frontend/src/index.html | 20 +-
frontend/src/main.ts | 3 +-
frontend/src/styles.scss | 174 +-
rat-excludes | 1 +
191 files changed, 10518 insertions(+), 2620 deletions(-)
copy .github/workflows/{i18n-check.yml => prettier-eslint.yaml} (80%)
create mode 100755 consumer/scripts/seed-openbanking.sh
copy
consumer/src/main/java/org/apache/fineract/consumer/audit/{command/api/AuditCommandController.java
=> query/api/AuditQueryController.java} (50%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{user/query/data/UserChargesQuery.java
=> audit/query/data/AuditEventListQuery.java} (89%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{infrastructure/oauth2/data/OAuth2ConsentData.java
=> audit/query/data/AuditEventQueryData.java} (79%)
copy consumer/src/main/java/org/apache/fineract/consumer/audit/{command =>
query}/data/AuditEventSource.java (93%)
copy
consumer/src/main/java/org/apache/fineract/consumer/audit/{command/service/AuditCommandService.java
=> query/data/AuditEventType.java} (60%)
copy consumer/src/main/java/org/apache/fineract/consumer/{infrastructure/audit
=> audit/query}/data/AuditSeverity.java (93%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/audit/query/domain/AuditEventQueryEntity.java
copy
consumer/src/main/java/org/apache/fineract/consumer/{user/query/data/UserChargesQueryResponse.java
=> audit/query/repository/AuditQueryRepository.java} (65%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{summary/query/service/SummaryQueryService.java
=> audit/query/service/AuditQueryService.java} (71%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/audit/query/service/AuditQueryServiceImpl.java
copy
consumer/src/main/java/org/apache/fineract/consumer/beneficiaries/command/exception/{BeneficiaryAccountInvalidException.java
=> BeneficiarySelfAccountException.java} (79%)
copy
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/{access/data/ResourceType.java
=> oauth2/data/RegisteredTppStatus.java} (87%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/oauth2/domain/RegisteredTpp.java
copy
consumer/src/main/java/org/apache/fineract/consumer/{openbanking/command/repository/OpenBankingConsentCommandRepository.java
=> infrastructure/oauth2/repository/RegisteredTppRepository.java} (73%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/infrastructure/oauth2/service/RegisteredTppClientAdapter.java
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/data/OtpConstants.java (94%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/data/OtpDestination.java (94%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/data/OtpMetadata.java (95%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/data/PendingOtp.java (96%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/exception/OtpDeliveryFailedException.java (94%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/exception/OtpDestinationInvalidException.java (94%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/exception/OtpTokenInvalidException.java (94%)
rename
consumer/src/main/java/org/apache/fineract/consumer/{otp/command/repository/OtpCommandRepository.java
=> infrastructure/otp/repository/OtpRepository.java} (94%)
rename consumer/src/main/java/org/apache/fineract/consumer/{otp/command =>
infrastructure/otp}/service/OtpEmailDeliveryService.java (92%)
rename
consumer/src/main/java/org/apache/fineract/consumer/{otp/command/service/OtpCommandService.java
=> infrastructure/otp/service/OtpService.java} (83%)
rename
consumer/src/main/java/org/apache/fineract/consumer/{otp/command/service/OtpCommandServiceImpl.java
=> infrastructure/otp/service/OtpServiceImpl.java} (81%)
copy
consumer/src/main/java/org/apache/fineract/consumer/loans/query/data/{LoanProductOptionQueryData.java
=> LoanTransactionQueryResponse.java} (80%)
copy
consumer/src/main/java/org/apache/fineract/consumer/savings/query/data/{SavingsProductOptionQueryData.java
=> SavingsTransactionQueryResponse.java} (80%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/transfers/query/api/TransfersQueryController.java
copy
consumer/src/main/java/org/apache/fineract/consumer/{user/command/data/UserStatus.java
=> transfers/query/data/TransferDirection.java} (87%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{savings/query/data/SavingsTransactionSearchQuery.java
=> transfers/query/data/TransferHistoryQuery.java} (89%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{loans/query/data/LoanTransactionQueryData.java
=> transfers/query/data/TransferQueryData.java} (82%)
rename
consumer/src/main/java/org/apache/fineract/consumer/{beneficiaries/query/data/BeneficiaryTemplateQueryData.java
=> transfers/query/data/TransferQueryResponse.java} (78%)
copy
consumer/src/main/java/org/apache/fineract/consumer/transfers/{command/exception/TransferAccessDeniedException.java
=> query/exception/TransferQueryAccessDeniedException.java} (80%)
copy
consumer/src/main/java/org/apache/fineract/consumer/transfers/{command/exception/TransferUpstreamUnavailableException.java
=> query/exception/TransferQueryUpstreamUnavailableException.java} (76%)
copy
consumer/src/main/java/org/apache/fineract/consumer/{summary/query/service/SummaryQueryService.java
=> transfers/query/service/TransfersQueryService.java} (71%)
create mode 100644
consumer/src/main/java/org/apache/fineract/consumer/transfers/query/service/TransfersQueryServiceImpl.java
copy
consumer/src/main/resources/db/changelog/{user/001-create-users-table.yaml =>
infrastructure/008-create-registered-tpps.yaml} (71%)
create mode 100644
consumer/src/test/java/org/apache/fineract/consumer/cucumber/hooks/RegisteredTppSeed.java
create mode 100644
consumer/src/test/java/org/apache/fineract/consumer/infrastructure/oauth2/service/RegisteredTppClientAdapterTest.java
rename
consumer/src/test/java/org/apache/fineract/consumer/{otp/command/repository/OtpCommandRepositoryTest.java
=> infrastructure/otp/repository/OtpRepositoryTest.java} (93%)
rename
consumer/src/test/java/org/apache/fineract/consumer/{otp/command/service/OtpCommandServiceImplTest.java
=> infrastructure/otp/service/OtpServiceImplTest.java} (69%)
create mode 100644
consumer/src/test/java/org/apache/fineract/consumer/transfers/query/service/TransfersQueryServiceImplTest.java
create mode 100644 frontend/.prettierignore
create mode 100644 frontend/eslint.config.js
copy frontend/{playwright.config.ts => src/app/core/i18n/i18n.service.ts} (57%)
copy frontend/src/app/core/{auth/device-fingerprint.ts =>
notifications/notification.service.ts} (55%)
create mode 100644
frontend/src/app/features/auth/forgot-password.component.spec.ts
create mode 100644
frontend/src/app/features/beneficiaries/beneficiaries.component.spec.ts
create mode 100644 frontend/src/app/features/demo/demo.component.ts
copy frontend/src/app/features/{savings/savings.store.spec.ts =>
demo/demo.store.spec.ts} (60%)
create mode 100644 frontend/src/app/features/demo/demo.store.ts
create mode 100644 frontend/src/app/features/loans/loan-apply.component.spec.ts
create mode 100644 frontend/src/app/features/loans/loan-repay.component.spec.ts
create mode 100644 frontend/src/app/features/loans/loan-repay.component.ts
create mode 100644
frontend/src/app/features/registration/registration.component.spec.ts
create mode 100644
frontend/src/app/features/settings/change-password.component.spec.ts
rename frontend/src/app/features/{profile =>
settings}/change-password.component.ts (74%)
create mode 100644 frontend/src/app/features/settings/settings.component.ts
copy frontend/src/app/features/{profile/profile.store.spec.ts =>
settings/settings.store.spec.ts} (56%)
copy frontend/src/app/features/{profile/profile.store.ts =>
settings/settings.store.ts} (52%)
create mode 100644
frontend/src/app/features/transfers/transfer-form.component.spec.ts
copy frontend/src/app/features/transfers/{transfer.component.ts =>
transfer-form.component.ts} (53%)
copy frontend/src/app/shared/css/{form.scss => pager.scss} (80%)
delete mode 100644 frontend/src/app/shared/models/account-types.ts
copy frontend/src/app/{api/consumer-api-error.ts =>
shared/utils/account-sort.ts} (75%)
