This is an automated email from the ASF dual-hosted git repository.
Aman-Mittal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/fineract-backoffice-ui.git
from f6593431 Merge pull request #566 from
Aman-Mittal/fix/ui-boundary-ratchet
add 56ff453f test(a11y): record the ion-select aria-required baseline as
one defect, not four
add 7b8b2f76 fix(lint): align number-literal-case with Prettier, and clear
the addressable unicorn baseline
add e5724817 feat(ui): let app-button navigate, without imposing a router
on every consumer
add 3d308d38 test(ui): check statically that every app-button declares a
type and can be named
add d8f8e2c0 refactor(ui): migrate 47 list screens onto the app-owned
button, icon and spinner
add 654aa483 fix(ui): keep app-button's link a real link, not a button
that routes
add e3f8372d docs(ui): trim the primitive comments to what a reader needs
add a8af4441 docs: drop comments that restate the code they sit above
new 27d5a441 Merge pull request #568 from
Aman-Mittal/chore/lint-debt-and-a11y-baseline
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/workflows/ci.yml | 6 +-
e2e/accessibility.spec.ts | 24 ++-
eslint-suppressions.json | 179 ---------------------
eslint.config.js | 4 +
package.json | 1 +
scripts/check-ui-primitives.mjs | 146 +++++++++++++++++
.../accounting/accounting-rules-list.component.ts | 32 ++--
.../financial-activity-mappings-list.component.ts | 32 ++--
.../provisioning-categories-list.component.ts | 33 ++--
.../provisioning-criteria-list.component.ts | 33 ++--
.../features/calendars/calendars-list.component.ts | 33 ++--
.../charges/client-charges-list.component.ts | 19 ++-
.../collateral/client-collateral-list.component.ts | 33 ++--
.../tabs/client-documents-list.component.ts | 45 +++---
.../tabs/client-family-members-list.component.ts | 47 +++---
.../tabs/client-identifiers-list.component.ts | 47 +++---
.../tabs/client-notes-list.component.test.ts | 139 ++++++++++++++++
.../clients/tabs/client-notes-list.component.ts | 47 +++---
.../client-transactions-list.component.ts | 19 ++-
.../fintech/asset-owners-list.component.ts | 25 ++-
.../groups/tabs/group-accounts-tab.component.ts | 6 +-
.../loans/charges/loan-charges-list.component.ts | 19 ++-
.../loans/guarantors/guarantors-list.component.ts | 33 ++--
.../interest-pauses-list.component.ts | 33 ++--
.../point-in-time/loans-point-in-time.component.ts | 2 +-
.../post-dated-checks-list.component.ts | 33 ++--
.../features/meetings/meetings-list.component.ts | 33 ++--
.../account-number-formats-list.component.ts | 33 ++--
.../organization/funds/funds-list.component.ts | 19 ++-
.../payment-types/payment-types-list.component.ts | 33 ++--
.../collateral-management-list.component.ts | 33 ++--
.../deposit-account-view.component.test.ts | 5 +-
.../fixed-deposit-products-list.component.ts | 19 ++-
.../floating-rates-list.component.ts | 19 ++-
.../interest-rate-charts-list.component.ts | 47 +++---
.../loan-originators-list.component.ts | 33 ++--
.../products/rates/rates-list.component.ts | 19 ++-
.../recurring-deposit-products-list.component.ts | 19 ++-
.../products/savings-accounts-list.component.ts | 71 ++++----
.../savings-charges-list.component.ts | 19 ++-
.../share-dividends-list.component.ts | 19 ++-
.../shares/share-account-view.component.test.ts | 5 +-
.../features/reporting/reports-list.component.ts | 19 ++-
.../reporting/run-report.component.test.ts | 5 +-
.../audit-logs/audit-logs-list.component.ts | 5 +-
.../security/roles/roles-list.component.ts | 19 ++-
.../spm/surveys/spm-surveys-list.component.ts | 33 ++--
.../adhoc-query/adhoc-query-list.component.ts | 33 ++--
.../data-tables/datatables-list.component.ts | 47 +++---
.../entity-data-table-checks-list.component.ts | 19 ++-
.../entity-mapping-list.component.ts | 33 ++--
.../features/system/hooks/hooks-list.component.ts | 33 ++--
.../scheduler-job-history.component.ts | 8 +-
src/app/features/system/sms/sms-list.component.ts | 33 ++--
.../checker-inbox/view-payload-dialog.component.ts | 6 +-
.../breach/wc-breach-list.component.ts | 33 ++--
.../wc-loan-products-list.component.ts | 33 ++--
.../loans/wc-loans-list.component.ts | 19 ++-
.../near-breach/wc-near-breach-list.component.ts | 33 ++--
.../data-table/data-table.component.test.ts | 2 +-
src/app/ui/button/button.component.test.ts | 77 +++++++--
src/app/ui/button/button.component.ts | 99 +++++++-----
src/app/ui/icon/icon.component.ts | 22 +--
src/app/ui/spinner/spinner.component.ts | 13 +-
64 files changed, 1130 insertions(+), 990 deletions(-)
create mode 100644 scripts/check-ui-primitives.mjs
create mode 100644
src/app/features/clients/tabs/client-notes-list.component.test.ts