This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
from 7f607f5a15 Merge pull request #6635
add 62a9fbdafe FINERACT-2883: migrate the credit bureau tests to feign
add a1247d029a FINERACT-2883: document the email and loan NPA payloads
add 2b78908bbc FINERACT-2883: add feign helpers for the teller and email
tests
add fbd2509c32 FINERACT-2883: migrate the teller and email tests to feign
add 95a310b167 FINERACT-2883: migrate SchedulerJobsTestResults to feign
add 755f50eef5 FINERACT-2883: remove the legacy helpers left without
callers
new 9f06fd7f68 Merge pull request #6561
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
config/checkstyle/restassured-baseline.xml | 8 -
.../campaigns/email/api/EmailApiResource.java | 10 +
.../email/api/EmailApiResourceSwagger.java | 52 +
.../api/CreditBureauConfigurationApiResource.java | 17 +
...reditBureauConfigurationApiResourceSwagger.java | 91 ++
.../api/CreditBureauIntegrationApiResource.java | 4 +-
...CreditBureauIntegrationApiResourceSwagger.java} | 27 +-
.../loanaccount/api/LoansApiResourceSwagger.java | 2 +
.../CreditBureauConfigurationTest.java | 23 +-
.../CreditBureauConfigurationValidationTest.java | 183 ++--
.../integrationtests/CreditBureauTest.java | 124 +--
.../integrationtests/SchedulerJobsTestResults.java | 1151 ++++++++------------
.../integrationtests/campaigns/EmailTest.java | 141 +--
...ava => CreditBureauIntegrationCommandsApi.java} | 20 +-
.../feign/helpers/FeignCreditBureauHelper.java | 96 ++
...gnTaxGroupHelper.java => FeignEmailHelper.java} | 36 +-
.../client/feign/helpers/FeignTellerHelper.java | 120 ++
.../client/feign/helpers/TellerCommandsApi.java | 44 +
.../client/feign/modules/FeignErrors.java | 17 +
.../common/CreditBureauConfigurationHelper.java | 95 --
.../common/CreditBureauIntegrationHelper.java | 46 -
.../common/StandingInstructionsHelper.java | 4 +-
.../common/accounting/AccountHelper.java | 10 -
.../common/accounting/JournalEntryHelper.java | 64 --
.../common/charges/ChargesHelper.java | 86 --
.../fixeddeposit/FixedDepositAccountHelper.java | 40 -
.../FixedDepositAccountStatusChecker.java | 11 -
.../common/loans/LoanStatusChecker.java | 22 -
.../common/loans/LoanTransactionHelper.java | 60 -
.../common/savings/SavingsAccountHelper.java | 38 -
.../AllocateCashToCashierValidationTest.java | 95 +-
.../teller/CashierSummaryAndTransactionsTest.java | 35 +-
.../teller/CashierTransactionsHelper.java | 183 ----
33 files changed, 1231 insertions(+), 1724 deletions(-)
create mode 100644
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/api/EmailApiResourceSwagger.java
create mode 100644
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationApiResourceSwagger.java
copy
fineract-provider/src/main/java/org/apache/fineract/{commands/api/MakercheckersApiResourceSwagger.java
=>
infrastructure/creditbureau/api/CreditBureauIntegrationApiResourceSwagger.java}
(57%)
copy
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/{ExternalServiceCommandsApi.java
=> CreditBureauIntegrationCommandsApi.java} (58%)
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/FeignCreditBureauHelper.java
copy
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/{FeignTaxGroupHelper.java
=> FeignEmailHelper.java} (50%)
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/FeignTellerHelper.java
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/TellerCommandsApi.java
delete mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/CreditBureauConfigurationHelper.java
delete mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/CreditBureauIntegrationHelper.java
delete mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/organization/teller/CashierTransactionsHelper.java