This is an automated email from the ASF dual-hosted git repository. Aman-Mittal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/fineract-consumer-facing.git
commit 6101de62cbd78b6ce9a6dc405204da1775629496 Merge: 35d979b 0390308 Author: Aman Mittal <[email protected]> AuthorDate: Wed Nov 18 16:42:08 2026 +0530 Merge pull request #265 from Kollishion/feat/scheduled-transfer-runs-window scheduledtransfers: bound the run history read to a date window .../service/StandingInstructionFineractClient.java | 8 +- .../StandingInstructionFineractClientImpl.java | 46 ++++-- .../api/ScheduledTransfersQueryController.java | 15 +- .../data/ScheduledTransferRunHistoryQuery.java | 3 + .../service/ScheduledTransfersQueryService.java | 5 +- .../ScheduledTransfersQueryServiceImpl.java | 30 +++- .../cucumber/steps/ScheduledTransfersSteps.java | 6 +- .../StandingInstructionFineractClientImplTest.java | 156 ++++++++++++++++++--- .../api/ScheduledTransfersQueryControllerTest.java | 28 +++- .../ScheduledTransfersQueryServiceImplTest.java | 134 ++++++++++++++++-- docs/consumer/features/scheduled-transfers.adoc | 17 ++- 11 files changed, 386 insertions(+), 62 deletions(-) diff --cc docs/consumer/features/scheduled-transfers.adoc index 8cdb648,3aa0c2a..f99579e --- a/docs/consumer/features/scheduled-transfers.adoc +++ b/docs/consumer/features/scheduled-transfers.adoc @@@ -273,9 -274,10 +274,10 @@@ The schedule itself (amount, frequency == Testing coverage * Unit: `ScheduledTransfersCommandServiceImplTest` covers the flag rejecting both commands before any check, source authorization, OTP purpose and step-up binding, every schedule rule, beneficiary limit (above and equal), unowned destinations, mismatched currencies, a step-up mismatch reserving nothing, monthly and weekly request mapping including the inclusive end date, reservation before the Fineract call and key forwarding, linking with its audit event, retries returning the linked r [...] - * Unit: `ScheduledTransfersQueryServiceImplTest` covers the flag rejecting both reads before any check, the list action authorized first, no Fineract call without rows, ownership checked once per source account and an unowned one leaving out only its transfers, weekly and monthly mapping including the inclusive end date, leaving out deleted, disabled, ended, and bank-created instructions, the newest-first order, an unlinked row matched by name but not on another source account, invalid [...] + * Unit: `ScheduledTransfersQueryServiceImplTest` covers the flag rejecting both reads before any check, the list action authorized first, no Fineract call without rows, ownership checked once per source account and an unowned one leaving out only its transfers, weekly and monthly mapping including the inclusive end date, leaving out deleted, disabled, ended, and bank-created instructions, the newest-first order, an unlinked row matched by name but not on another source account, invalid [...] + * Unit: `StandingInstructionFineractClientImplTest` covers the window applied in the BFF (runs inside and outside it, the inclusive end date, stopping at the first older run, continuing while every run is inside, runs with no date kept), reads spanning more than one Fineract page keeping Fineract's order on every page, paging until the reported total, stopping at a full page that reaches the total without another request, an empty result for a missing response, and two identical failed [...] * Unit: `BeneficiaryScheduledTransferLookupAdapterTest` covers no Fineract call without rows, an active linked instruction counting, a cancelled, ended, bank-created, or other-account instruction not counting, an instruction with an end date counting when Fineract reports no date, an unlinked row counting when Fineract has its instruction by name but not otherwise, a row a confirm is working on counting without a Fineract call, only an amount above the limit counting (and an instruction [...] -* Cucumber: `scheduledtransfers.feature` (glue in `cucumber.steps.ScheduledTransfersSteps`) creates a weekly instruction between the customer's own accounts, a monthly one to a beneficiary, and a monthly one starting on the 31st, checking each through Fineract's standing instruction list; rejects an amount above the beneficiary limit, an unregistered destination, another client's source account, and a start date in the past; checks that a retried confirm with the same key creates one in [...] +* Cucumber: `scheduledtransfers.feature` (glue in `cucumber.steps.ScheduledTransfersSteps`) creates a weekly instruction between the customer's own accounts, a monthly one to a beneficiary, and a monthly one starting on the 31st, checking each through Fineract's standing instruction list; rejects an amount above the beneficiary limit, an unregistered destination, another client's source account, and a start date in the past; checks that a retried confirm with the same key creates one in [...] == Design rationale
