This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
from a065091918 Merge pull request #6876 from DakshRJain737/FINERACT-3098
add 157652c17d FINERACT-2298: migrate Standing Instructions to
CommandDispatcher
new 5bd59e7685 Merge pull request #6034 from aditinikam/FINERACT-2298-v2
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
fineract-account-transfer/dependencies.gradle | 3 +
.../api/StandingInstructionApiResource.java | 158 ++++++----
.../api/StandingInstructionApiResourceSwagger.java | 87 ------
.../command/StandingInstructionCreateCommand.java | 6 +-
.../command/StandingInstructionDeleteCommand.java | 6 +-
.../command/StandingInstructionUpdateCommand.java | 6 +-
.../data/StandingInstructionDataValidator.java | 308 ------------------
.../StandingInstructionCreationRequest.java | 104 ++++--
.../request/StandingInstructionDeleteRequest.java | 9 +-
.../request/StandingInstructionUpdateRequest.java | 92 ++++++
.../request/StandingInstructionUpdatesRequest.java | 48 ---
.../StandingInstructionCreateResponse.java | 6 +-
.../StandingInstructionDeleteResponse.java | 4 +-
.../StandingInstructionUpdateResponse.java | 4 +-
.../domain/AccountTransferStandingInstruction.java | 169 +---------
.../CreateStandingInstructionCommandHandler.java | 41 ---
.../DeleteStandingInstructionCommandHandler.java | 41 ---
.../StandingInstructionCreateCommandHandler.java | 19 +-
.../StandingInstructionDeleteCommandHandler.java | 23 +-
.../StandingInstructionUpdateCommandHandler.java | 19 +-
.../UpdateStandingInstructionCommandHandler.java | 41 ---
.../ExecuteStandingInstructionsManagerConfig.java | 6 +-
.../StandingInstructionItemProcessor.java | 6 +-
.../StandingInstructionItemReader.java | 6 +-
.../StandingInstructionPartitioner.java | 6 +-
...ce.java => StandingInstructionReadService.java} | 2 +-
.../StandingInstructionWritePlatformService.java | 32 --
.../service/StandingInstructionWriteService.java | 35 +++
.../StandingInstructionCreateValidator.java | 174 +++++++++++
.../StandingInstructionUpdateValidator.java | 59 ++++
.../validation/ValidStandingInstructionCreate.java | 20 +-
.../validation/ValidStandingInstructionUpdate.java | 21 +-
.../data/StandingInstructionDataValidatorTest.java | 90 ------
.../AccountTransferStandingInstructionTest.java | 74 -----
.../StandingInstructionPartitionerTest.java | 4 +-
.../StandingInstructionRecurrenceTest.java | 4 +-
.../StandingInstructionRequestValidationTest.java | 347 +++++++++++++++++++++
.../commands/service/CommandWrapperBuilder.java | 25 --
.../infrastructure/core/service/DateUtils.java | 50 +++
.../CommandParameterAuthorizationManager.java | 60 ++++
.../infrastructure/core/config/SecurityConfig.java | 26 ++
.../domain/StandingInstructionAssembler.java | 95 ------
.../ExecuteStandingInstructionsWorkerConfig.java | 8 +-
...ava => StandingInstructionReadServiceImpl.java} | 6 +-
...tandingInstructionWritePlatformServiceImpl.java | 153 ---------
.../StandingInstructionWriteServiceImpl.java | 343 ++++++++++++++++++++
.../account/starter/AccountConfiguration.java | 31 +-
.../src/main/resources/application.properties | 24 ++
...tandingInstructionCommandAuthorizationTest.java | 108 +++++++
.../StandingInstructionItemProcessorTest.java | 4 +-
.../StandingInstructionItemReaderTest.java | 4 +-
...=> StandingInstructionReadServiceImplTest.java} | 6 +-
.../StandingInstructionWriteServiceImplTest.java | 242 ++++++++++++++
.../main/resources/ValidationMessages.properties | 46 +++
.../integrationtests/SchedulerJobsTestResults.java | 50 ++-
.../helpers/StandingInstructionCommandsApi.java | 43 +++
.../common/StandingInstructionsHelper.java | 62 ++--
.../StandingInstructionMonthEndRecurrenceTest.java | 10 +-
.../StandingInstructionUpdateDeleteTest.java | 160 ++++++++++
59 files changed, 2169 insertions(+), 1467 deletions(-)
copy
fineract-command-test/src/main/java/org/apache/fineract/command/test/sample/command/DummyCommand.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/command/StandingInstructionCreateCommand.java
(79%)
copy
fineract-command-test/src/main/java/org/apache/fineract/command/test/sample/command/DummyCommand.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/command/StandingInstructionDeleteCommand.java
(79%)
copy
fineract-command-test/src/main/java/org/apache/fineract/command/test/sample/command/DummyCommand.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/command/StandingInstructionUpdateCommand.java
(79%)
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/StandingInstructionDataValidator.java
copy
fineract-provider/src/main/java/org/apache/fineract/portfolio/collateralmanagement/data/LoanCollateralDeleteRequest.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/request/StandingInstructionDeleteRequest.java
(87%)
create mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/request/StandingInstructionUpdateRequest.java
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/request/StandingInstructionUpdatesRequest.java
copy
fineract-provider/src/main/java/org/apache/fineract/portfolio/address/data/AddressCreateResponse.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/response/StandingInstructionCreateResponse.java
(89%)
copy
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/data/FloatingRateUpdateResponse.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/response/StandingInstructionDeleteResponse.java
(89%)
copy
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/data/FloatingRateUpdateResponse.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/data/response/StandingInstructionUpdateResponse.java
(89%)
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/CreateStandingInstructionCommandHandler.java
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/DeleteStandingInstructionCommandHandler.java
copy
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/handler/FloatingRateCreateCommandHandler.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/StandingInstructionCreateCommandHandler.java
(62%)
copy
fineract-document/src/main/java/org/apache/fineract/infrastructure/documentmanagement/handler/DocumentCreateCommandHandler.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/StandingInstructionDeleteCommandHandler.java
(60%)
copy
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/handler/FloatingRateUpdateCommandHandler.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/StandingInstructionUpdateCommandHandler.java
(62%)
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/handler/UpdateStandingInstructionCommandHandler.java
rename
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/service/{StandingInstructionReadPlatformService.java
=> StandingInstructionReadService.java} (97%)
delete mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionWritePlatformService.java
create mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionWriteService.java
create mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/validation/StandingInstructionCreateValidator.java
create mode 100644
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/validation/StandingInstructionUpdateValidator.java
copy
fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDate.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/validation/ValidStandingInstructionCreate.java
(71%)
copy
fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDate.java
=>
fineract-account-transfer/src/main/java/org/apache/fineract/portfolio/account/validation/ValidStandingInstructionUpdate.java
(66%)
delete mode 100644
fineract-account-transfer/src/test/java/org/apache/fineract/portfolio/account/data/StandingInstructionDataValidatorTest.java
delete mode 100644
fineract-account-transfer/src/test/java/org/apache/fineract/portfolio/account/domain/AccountTransferStandingInstructionTest.java
create mode 100644
fineract-account-transfer/src/test/java/org/apache/fineract/portfolio/account/validation/StandingInstructionRequestValidationTest.java
create mode 100644
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/CommandParameterAuthorizationManager.java
delete mode 100644
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/domain/StandingInstructionAssembler.java
rename
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/{StandingInstructionReadPlatformServiceImpl.java
=> StandingInstructionReadServiceImpl.java} (99%)
delete mode 100644
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionWritePlatformServiceImpl.java
create mode 100644
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/StandingInstructionWriteServiceImpl.java
create mode 100644
fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/config/StandingInstructionCommandAuthorizationTest.java
rename
fineract-provider/src/test/java/org/apache/fineract/portfolio/account/service/{StandingInstructionReadPlatformServiceImplTest.java
=> StandingInstructionReadServiceImplTest.java} (95%)
create mode 100644
fineract-provider/src/test/java/org/apache/fineract/portfolio/account/service/StandingInstructionWriteServiceImplTest.java
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/StandingInstructionCommandsApi.java
create mode 100644
integration-tests/src/test/java/org/apache/fineract/integrationtests/savings/StandingInstructionUpdateDeleteTest.java