This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


    from c20329359e Merge pull request #6963 from 
Alimohamed147/FINERACT-3284-sql-092
     add 67d935cccb FINERACT-2240: migrate Charges to CommandDispatcher
     new 8c23e73c7a Merge pull request #6167 from aditinikam/FINERACT-2240

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 fineract-charge/dependencies.gradle                |   2 +
 .../portfolio/charge/api/ChargesApiResource.java   | 104 ++--
 .../charge/api/ChargesApiResourceSwagger.java      | 349 ------------
 .../charge/command/ChargeCreateCommand.java        |   7 +-
 .../charge/command/ChargeDeleteCommand.java        |   7 +-
 .../charge/command/ChargeUpdateCommand.java        |   7 +-
 .../portfolio/charge/data/ChargeCreateRequest.java |  98 ++++
 .../charge/data/ChargeCreateResponse.java          |   4 +-
 .../portfolio/charge/data/ChargeDeleteRequest.java |   6 +-
 .../charge/data/ChargeDeleteResponse.java          |   4 +-
 .../portfolio/charge/data/ChargeUpdateRequest.java | 107 ++++
 .../charge/data/ChargeUpdateResponse.java          |   4 +-
 .../fineract/portfolio/charge/domain/Charge.java   | 443 +--------------
 .../portfolio/charge/domain/ChargeRepository.java  |  12 +
 .../charge/handler/ChargeCreateCommandHandler.java |  20 +-
 .../charge/handler/ChargeDeleteCommandHandler.java |  20 +-
 .../charge/handler/ChargeUpdateCommandHandler.java |  20 +-
 .../CreateChargeDefinitionCommandHandler.java      |  42 --
 .../DeleteChargeDefinitionCommandHandler.java      |  42 --
 .../UpdateChargeDefinitionCommandHandler.java      |  42 --
 .../portfolio/charge/request/ChargeRequest.java    |  61 ---
 ...geDefinitionCommandFromApiJsonDeserializer.java | 605 ---------------------
 ...PlatformService.java => ChargeReadService.java} |   2 +-
 ...latformService.java => ChargeWriteService.java} |  19 +-
 .../validation/ChargeAmortizationValidator.java    | 143 +++++
 .../charge/validation/ChargeCreateValidator.java   | 169 ++++++
 .../charge/validation/ChargeRulesChecker.java      | 115 ++++
 .../charge/validation/ChargeUpdateValidator.java   | 208 +++++++
 .../charge/validation/ValidChargeCreate.java       |   8 +-
 .../charge/validation/ValidChargeUpdate.java       |   8 +-
 .../portfolio/charge/domain/ChargeTest.java        | 153 ------
 .../ChargeAmortizationConfigurationTest.java       | 307 -----------
 ...finitionCommandFromApiJsonDeserializerTest.java |  64 ---
 .../charge/validation/ChargeValidationTest.java    | 564 +++++++++++++++++++
 .../commands/service/CommandWrapperBuilder.java    |  25 -
 .../WorkingCapitalChargeRequestFactory.java        |   6 +-
 ...talLoanProductAdvancedAccountingTestHelper.java |   8 +-
 .../stepdef/loan/ChargeAmortizationStepDef.java    |  28 +-
 .../fineract/test/stepdef/loan/ChargeStepDef.java  |  32 +-
 .../stepdef/loan/WorkingCapitalChargeStepDef.java  |  27 +-
 .../global/ChargeGlobalInitializerStep.java        |  15 +-
 .../features/LoanChargesDownPayment.feature        |  10 +-
 .../features/WorkingCapitalLoanCharge.feature      |  16 +-
 .../BulkImportWorkbookPopulatorServiceImpl.java    |  13 +-
 .../infrastructure/core/config/SecurityConfig.java |  12 +
 ...ServiceImpl.java => ChargeReadServiceImpl.java} |   2 +-
 ...hargeWritePlatformServiceJpaRepositoryImpl.java | 306 -----------
 .../charge/service/ChargeWriteServiceImpl.java     | 562 +++++++++++++++++++
 .../charge/starter/ChargeConfiguration.java        |  28 +-
 .../client/api/ClientChargesApiResource.java       |   6 +-
 .../loanaccount/api/LoanChargesApiResource.java    |   6 +-
 .../loanaccount/api/LoansApiResource.java          |  12 +-
 .../service/LoanReadPlatformServiceImpl.java       |  10 +-
 .../starter/LoanAccountConfiguration.java          |   6 +-
 .../loanproduct/api/LoanProductsApiResource.java   |   8 +-
 .../LoanProductReadPlatformServiceImpl.java        |   6 +-
 .../starter/LoanProductConfiguration.java          |   6 +-
 .../api/FixedDepositProductsApiResource.java       |  10 +-
 .../api/RecurringDepositProductsApiResource.java   |  10 +-
 .../api/SavingsAccountChargesApiResource.java      |   7 +-
 .../savings/api/SavingsProductsApiResource.java    |  10 +-
 .../DepositAccountReadPlatformServiceImpl.java     |  14 +-
 ...ingsAccountTemplateReadPlatformServiceImpl.java |  18 +-
 .../savings/starter/SavingsConfiguration.java      |  10 +-
 .../ShareAccountReadPlatformServiceImpl.java       |  11 +-
 .../start/ShareAccountsConfiguration.java          |  11 +-
 .../ShareProductReadPlatformServiceImpl.java       |  10 +-
 .../starter/ShareProductsConfiguration.java        |   6 +-
 .../src/main/resources/application.properties      |  20 +
 ...BulkImportWorkbookPopulatorServiceImplTest.java |   4 +-
 ...eWritePlatformServiceJpaRepositoryImplTest.java | 108 ----
 .../charge/service/ChargeWriteServiceImplTest.java | 521 ++++++++++++++++++
 ...ansApiResourceRetrieveApprovalTemplateTest.java |   4 +-
 ...nProductsApiResourceTemplateDatatablesTest.java |   4 +-
 .../api/SavingsAccountChargesApiResourceTest.java  |   4 +-
 .../main/resources/ValidationMessages.properties   |  48 ++
 .../api/WorkingCapitalLoanChargesApiResource.java  |   6 +-
 .../AccrualsOnLoanClosureTest.java                 |  12 +-
 .../ChargeAmortizationConfigurationTest.java       |  28 +-
 .../fineract/integrationtests/ChargesTest.java     | 112 ++--
 .../integrationtests/ClientChargeRoundingTest.java |  16 +-
 .../ClientLoanIntegrationTest.java                 |  10 +-
 ...DueDateRespectiveLoanRepaymentScheduleTest.java |   4 +-
 .../LoanCOBAccountLockCatchupInlineCOBTest.java    |   4 +-
 .../LoanCatchUpIntegrationTest.java                |   4 +-
 .../LoanChargeProgressiveTest.java                 |   6 +-
 .../integrationtests/LoanChargeRoundingTest.java   |  68 +--
 .../LoanChargeSpecificDueDateTest.java             |   4 +-
 .../LoanChargeTaxIntegrationTest.java              |  38 +-
 .../LoanChargesMultipleDebitAccountsTest.java      |  60 +-
 .../LoanInterestRecalculationCOBTest.java          |   6 +-
 .../LoanRepaymentScheduleWithDownPaymentTest.java  |  10 +-
 ...LoanSpecificDueDateChargeAfterMaturityTest.java |   4 +-
 .../LoanTransactionAccrualActivityPostingTest.java |   8 +-
 .../LoanTransactionInterestPaymentWaiverTest.java  |   6 +-
 .../integrationtests/LoanWaiveChargeTest.java      |  12 +-
 ...chantIssuedRefundAdditionalInstallmentTest.java |   4 +-
 .../ProgressiveLoanUndoDisbursementTest.java       |   6 +-
 .../SavingsAccountChargeRoundingTest.java          |  24 +-
 .../SavingsAccountChargeUpdateTest.java            |  16 +-
 .../integrationtests/SchedulerJobsTestResults.java |  12 +-
 .../ShareAccountChargeRoundingTest.java            |  56 +-
 .../integrationtests/TaxComponentEditLockTest.java |   4 +-
 .../TaxGroupComponentStartDateTest.java            |   4 +-
 ...ingCapitalLoanTransactionSummaryReportTest.java |  12 +-
 .../importhandler/loan/LoanImportHandlerTest.java  |   4 +-
 .../client/feign/FeignLoanTestBase.java            |  10 +-
 .../client/feign/helpers/FeignChargesHelper.java   |  50 +-
 .../feign/helpers/FeignSavingsChargeHelper.java    |   8 +-
 .../helpers/FeignWorkingCapitalLoanHelper.java     |   8 +-
 .../feign/modules/ChargeRequestBuilders.java       |  47 +-
 .../feign/modules/SavingsRequestBuilders.java      |  30 +-
 .../modules/WorkingCapitalLoanRequestBuilders.java |  37 +-
 .../FeignCobBulkEventRecordingWindowTest.java      |   8 +-
 ...ignOfficeSpecificLoanProductVisibilityTest.java |   4 +-
 .../FeignWorkingCapitalChargeProductTest.java      | 107 ++--
 .../integrationtests/cob/CobPartitioningTest.java  |   4 +-
 .../shares/ShareAccountIntegrationTests.java       |   4 +-
 .../inlinecob/InlineLoanCOBTest.java               |   4 +-
 .../LoanPenaltyBackdatedTransactionTest.java       |   8 +-
 .../loan/reaging/LoanReAgingIntegrationTest.java   |   4 +-
 .../savings/AccountTransferWithdrawalFeeTest.java  |   6 +-
 122 files changed, 3370 insertions(+), 3275 deletions(-)
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java
 copy 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/command/JobUpdateCommand.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/command/ChargeCreateCommand.java
 (83%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/command/JobUpdateCommand.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/command/ChargeDeleteCommand.java
 (83%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/command/JobUpdateCommand.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/command/ChargeUpdateCommand.java
 (83%)
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeCreateRequest.java
 copy 
fineract-provider/src/main/java/org/apache/fineract/template/data/TemplateUpdateResponse.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeCreateResponse.java
 (90%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/HookDeleteRequest.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeDeleteRequest.java
 (88%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/template/data/TemplateUpdateResponse.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeDeleteResponse.java
 (90%)
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeUpdateRequest.java
 copy 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/data/HookUpdateResponse.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/data/ChargeUpdateResponse.java
 (91%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/portfolio/note/handler/NoteUpdateCommandHandler.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/ChargeCreateCommandHandler.java
 (65%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/portfolio/note/handler/NoteUpdateCommandHandler.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/ChargeDeleteCommandHandler.java
 (65%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/portfolio/note/handler/NoteUpdateCommandHandler.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/ChargeUpdateCommandHandler.java
 (65%)
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/CreateChargeDefinitionCommandHandler.java
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/DeleteChargeDefinitionCommandHandler.java
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/handler/UpdateChargeDefinitionCommandHandler.java
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/request/ChargeRequest.java
 delete mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/serialization/ChargeDefinitionCommandFromApiJsonDeserializer.java
 rename 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/service/{ChargeReadPlatformService.java
 => ChargeReadService.java} (99%)
 rename 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/service/{ChargeWritePlatformService.java
 => ChargeWriteService.java} (53%)
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ChargeAmortizationValidator.java
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ChargeCreateValidator.java
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ChargeRulesChecker.java
 create mode 100644 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ChargeUpdateValidator.java
 copy 
fineract-provider/src/main/java/org/apache/fineract/organisation/staff/validation/StaffForceStatus.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ValidChargeCreate.java
 (83%)
 copy 
fineract-provider/src/main/java/org/apache/fineract/organisation/staff/validation/StaffForceStatus.java
 => 
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/validation/ValidChargeUpdate.java
 (83%)
 delete mode 100644 
fineract-charge/src/test/java/org/apache/fineract/portfolio/charge/domain/ChargeTest.java
 delete mode 100644 
fineract-charge/src/test/java/org/apache/fineract/portfolio/charge/serialization/ChargeAmortizationConfigurationTest.java
 delete mode 100644 
fineract-charge/src/test/java/org/apache/fineract/portfolio/charge/serialization/ChargeDefinitionCommandFromApiJsonDeserializerTest.java
 create mode 100644 
fineract-charge/src/test/java/org/apache/fineract/portfolio/charge/validation/ChargeValidationTest.java
 rename 
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/{ChargeReadPlatformServiceImpl.java
 => ChargeReadServiceImpl.java} (99%)
 delete mode 100644 
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeWritePlatformServiceJpaRepositoryImpl.java
 create mode 100644 
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeWriteServiceImpl.java
 delete mode 100644 
fineract-provider/src/test/java/org/apache/fineract/portfolio/charge/service/ChargeWritePlatformServiceJpaRepositoryImplTest.java
 create mode 100644 
fineract-provider/src/test/java/org/apache/fineract/portfolio/charge/service/ChargeWriteServiceImplTest.java

Reply via email to