Updated Branches: refs/heads/develop 719e3ff3b -> f92dd51e9
Added JSDoc file annotation with @suppress to make the remaining GCC type warnings go away. There are small inconsistencies between the AS and goog JS type (e.g. in goog, 'string' is not an Object), that we cannot compensate for. Since the AS compiler takes care of the type checking on the AS code, IMHO we need not worry that we cover up any runtime errors with this @suppress. Signed-off-by: Erik de Bruin <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/b3f4b7e9 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/b3f4b7e9 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/b3f4b7e9 Branch: refs/heads/develop Commit: b3f4b7e9454f8a8d1e241922dc0deffc6d653e06 Parents: 719e3ff Author: Erik de Bruin <[email protected]> Authored: Sat Nov 16 15:43:28 2013 +0100 Committer: Erik de Bruin <[email protected]> Committed: Sat Nov 16 15:43:28 2013 +0100 ---------------------------------------------------------------------- .../compiler/internal/codegen/js/goog/JSGoogEmitter.java | 9 +++++++++ .../internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java | 9 +++++++++ 2 files changed, 18 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/b3f4b7e9/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java ---------------------------------------------------------------------- diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java index dc039a9..717a24c 100644 --- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java +++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java @@ -110,6 +110,15 @@ public class JSGoogEmitter extends JSEmitter implements IJSGoogEmitter if (type == null) return; + writeNewline("/**"); + writeNewline(" * " + type.getQualifiedName()); + writeNewline(" *"); + writeNewline(" * @fileoverview"); + writeNewline(" *"); + writeNewline(" * @suppress {checkTypes}"); + writeNewline(" */"); + writeNewline(); + /* goog.provide('x');\n\n */ write(JSGoogEmitterTokens.GOOG_PROVIDE); write(ASEmitterTokens.PAREN_OPEN); http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/b3f4b7e9/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java ---------------------------------------------------------------------- diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java index 68bad5e..f722223 100644 --- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java +++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java @@ -1380,6 +1380,15 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements String cname = node.getFileNode().getName(); String bcname = node.getBaseClassName(); + writeNewline("/**"); + writeNewline(" * " + cname); + writeNewline(" *"); + writeNewline(" * @fileoverview"); + writeNewline(" *"); + writeNewline(" * @suppress {checkTypes}"); + writeNewline(" */"); + writeNewline(); + emitHeaderLine(cname, true); // provide writeNewline(); emitHeaderLine(bcname);
