Repository: flex-utilities Updated Branches: refs/heads/feature/pmd-5.2-language-module 14e8771e2 -> 526c1e73e
http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/naming.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/naming.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/naming.xml index 4a94511..9bdead0 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/naming.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/naming.xml @@ -27,7 +27,7 @@ The Basic As3 Ruleset contains a collection of good practices which everyone should follow. </description> - <rule class="com.adobe.ac.pmd.rules.naming.TooShortVariableRule" + <rule class="org.apache.flex.pmd.rules.naming.TooShortVariableRule" message="This variable name is too short ({0} characters minimum, but {1} actually)"> <description>Detects when a field, local, or parameter has a very short name.</description> <priority>5</priority> @@ -49,7 +49,7 @@ public class Something </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.PackageCaseRule" + <rule class="org.apache.flex.pmd.rules.naming.PackageCaseRule" message="A package name should be lower case ({0})"> <description>Detects when a package definition contains upper case characters.</description> <priority>3</priority> @@ -65,7 +65,7 @@ package com.MyCompany // VIOLATION <- should be lower case name </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.VariableNameEndingWithNumericRule" + <rule class="org.apache.flex.pmd.rules.naming.VariableNameEndingWithNumericRule" message="Using digits at the end of a symbol does not help understanging the meaning of it. ({0})"> <priority>3</priority> <example> @@ -78,7 +78,7 @@ public class SomeClass </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.PropertyHiddenByLocalVariableRule" + <rule class="org.apache.flex.pmd.rules.naming.PropertyHiddenByLocalVariableRule" message="A class property is hidden by this local variable ({0})"> <priority>3</priority> <example> @@ -94,7 +94,7 @@ public class SomeClass </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.IncorrectClassCase" + <rule class="org.apache.flex.pmd.rules.naming.IncorrectClassCase" message="A class name must start by an uppercase character"> <description></description> <priority>3</priority> @@ -105,7 +105,7 @@ public class foo // VIOLATION </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.WronglyNamedVariableRule" + <rule class="org.apache.flex.pmd.rules.naming.WronglyNamedVariableRule" message="This variable ({0}) seems to be incorrectly named. Let your creativity flow"> <priority>3</priority> <example> @@ -123,22 +123,22 @@ public class SomeClass </example> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.BooleanAttributeShouldContainIsHasRule" + <rule class="org.apache.flex.pmd.rules.naming.BooleanAttributeShouldContainIsHasRule" message="Differentiate the Boolean variables from other variable types ({0}); for example: canAnimate, isConnected, or hasChildren."> <priority>5</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.CapitalizeConstantsRule" + <rule class="org.apache.flex.pmd.rules.naming.CapitalizeConstantsRule" message="Constant variables should be in all CAPS with each word separated by an underscore ({0})"> <priority>3</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.InterfaceNamingRule" + <rule class="org.apache.flex.pmd.rules.naming.InterfaceNamingRule" message="Interface name should start with I"> <priority>1</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.TooLongFunctionNameRule" + <rule class="org.apache.flex.pmd.rules.naming.TooLongFunctionNameRule" message="This function name ({0}) is too long ({1} characters minimum, but {2} actually)"> <priority>5</priority> <properties> @@ -148,7 +148,7 @@ public class SomeClass </properties> </rule> - <rule class="com.adobe.ac.pmd.rules.naming.IncorrectEventHandlerNameRule" + <rule class="org.apache.flex.pmd.rules.naming.IncorrectEventHandlerNameRule" message="This event handler name ({0}) is not correct. You should use [{1}] as prefix and [{2}] as suffix"> <priority>5</priority> <properties> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/parsley.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/parsley.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/parsley.xml index 1afd3c9..8803727 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/parsley.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/parsley.xml @@ -29,7 +29,7 @@ </description> <rule - class="com.adobe.ac.pmd.rules.parsley.InaccessibleMetaDataRule" + class="org.apache.flex.pmd.rules.parsley.InaccessibleMetaDataRule" message="Parsley metadata should not be placed on inaccessible members."> <description>Parsley can only process metadata that is placed onto public members.</description> <priority>1</priority> @@ -42,7 +42,7 @@ private function doSomething() : void // VIOLATION </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.MismatchedManagedEventRule" + class="org.apache.flex.pmd.rules.parsley.MismatchedManagedEventRule" message="Managed events should have matching [Event] metadata"> <description>Each managed event should have matching [Event] metadata.</description> <priority>1</priority> @@ -56,7 +56,7 @@ public class MyClass </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.MessageInterceptorSignatureRule" + class="org.apache.flex.pmd.rules.parsley.MessageInterceptorSignatureRule" message="The signature of the message interceptor {0} is not correct. {1}."> <description></description> <priority>1</priority> @@ -87,7 +87,7 @@ public function messageInterceptor( processor : MessageProcessor, type : MyMessa </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.MisplacedMetaDataRule" + class="org.apache.flex.pmd.rules.parsley.MisplacedMetaDataRule" message="This metadata {0} is misplaced"> <description></description> <priority>1</priority> @@ -96,7 +96,7 @@ public function messageInterceptor( processor : MessageProcessor, type : MyMessa </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.RedundantMessageHandlerTypeAttributeRule" + class="org.apache.flex.pmd.rules.parsley.RedundantMessageHandlerTypeAttributeRule" message="This type metadata argument is redundant with the handler argument type"> <description></description> <priority>3</priority> @@ -111,7 +111,7 @@ public function doSomething( message : MyMessage ) : void </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.RedundantMethodAttributeRule" + class="org.apache.flex.pmd.rules.parsley.RedundantMethodAttributeRule" message="This method metadata argument is redundant with the handler name"> <priority>3</priority> <example> <![CDATA[ @@ -124,7 +124,7 @@ public function doSomething( message : MyMessage ) : void </rule> <rule - class="com.adobe.ac.pmd.rules.parsley.UnknownMetaDataAttributeRule" + class="org.apache.flex.pmd.rules.parsley.UnknownMetaDataAttributeRule" message="This metadata attribute {0} is unknown"> <description></description> <priority>1</priority> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/performance.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/performance.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/performance.xml index ed46d9b..08e41e8 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/performance.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/performance.xml @@ -27,7 +27,7 @@ This Ruleset contains a collection of good practices related to the performance (CPU and memory). </description> - <rule class="com.adobe.ac.pmd.rules.performance.DynamicFiltersUsedInPopup" + <rule class="org.apache.flex.pmd.rules.performance.DynamicFiltersUsedInPopup" message="A popup should not use dynamic filters"> <description>Prefer using embed filters in assets</description> <priority>3</priority> @@ -35,7 +35,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.CyclomaticComplexityRule" + <rule class="org.apache.flex.pmd.rules.performance.CyclomaticComplexityRule" message="This method is too complex. Maximum complexity is {0}, but its cyclomatic complexity was {1}"> <priority>3</priority> <properties> @@ -45,23 +45,23 @@ </properties> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.HeavyConstructorRule" + <rule class="org.apache.flex.pmd.rules.performance.HeavyConstructorRule" message="Constructor must be as lightweight as possible. No control statement allowed, whereas a cyclomatic complexe of {0} has been detected"> <description><![CDATA[The Just-In-Time compiler does not compile constructors. Make them as lightweight as possible, or move the complexity of the code to a method called by the constructor. Then the complexity will be compiled by the JIT.]]></description> <priority>3</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.CreationPolicySetToAllRule" + <rule class="org.apache.flex.pmd.rules.performance.CreationPolicySetToAllRule" message="creationPolicy to ALL impacts the performance significantly"> <priority>1</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.BindableClassRule" + <rule class="org.apache.flex.pmd.rules.performance.BindableClassRule" message="Globally bindable classes can lead to unexpected behaviour especially when you have a setter to a property, and hits the performance of the application"> <priority>3</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.AvoidInstanciationInLoopRule" + <rule class="org.apache.flex.pmd.rules.performance.AvoidInstanciationInLoopRule" message="Instanciating a variable in a loop can be expensive"> <description></description> <priority>5</priority> @@ -69,7 +69,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.AvoidDeclarationInLoopRule" + <rule class="org.apache.flex.pmd.rules.performance.AvoidDeclarationInLoopRule" message="Declaring a variable in a loop can be expensive"> <description></description> <priority>5</priority> @@ -77,18 +77,18 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.DeeplyNestedIfRule" + <rule class="org.apache.flex.pmd.rules.performance.DeeplyNestedIfRule" message="Nested if statements are not a good design"> <priority>3</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.RecursiveStyleManagerRule" + <rule class="org.apache.flex.pmd.rules.performance.RecursiveStyleManagerRule" message="Detect calls to the StyleManager that donât pass âfalseâ as the second parameter"> <description>A recursive style manager call can be a very expensive operation, causing parts of the UI to flicker visibly. Instead it is preferable to defer the creation of parts of the UI that depend on a runtime CSS SWF until after the SWF has been loaded. In this case a recursive call is not required.</description> <priority>3</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.AvoidUsingMathFloorRule" + <rule class="org.apache.flex.pmd.rules.performance.AvoidUsingMathFloorRule" message="VM will automatically do the rounding when using an int, so it should be : var position:int = floatingValue;"> <priority>5</priority> <example> @@ -96,7 +96,7 @@ var position:Number = Math.floor ( floatingValue ); </example> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.AvoidUsingMathCeilRule" + <rule class="org.apache.flex.pmd.rules.performance.AvoidUsingMathCeilRule" message="VM will automatically do the rounding when using an int, so should be : var position:int = floatingValue + 1;"> <priority>5</priority> <example> @@ -104,7 +104,7 @@ var position:Number = Math.ceil ( floatingValue ); </example> </rule> - <rule class="com.adobe.ac.pmd.rules.performance.AvoidUsingMathRoundRule" + <rule class="org.apache.flex.pmd.rules.performance.AvoidUsingMathRoundRule" message="manual calculation will be much faster : var position:int = (floatingValue > 0.0) ? int(floatingValue + 0.5) : int(floatingValue - 0.5);"> <priority>5</priority> <example> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/security.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/security.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/security.xml index 1955467..05b98e6 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/security.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/security.xml @@ -27,7 +27,7 @@ The Security AS3 Ruleset contains a collection of best practices related to secure code. </description> - <rule class="com.adobe.ac.pmd.rules.security.InsecureExactSettingsRule" + <rule class="org.apache.flex.pmd.rules.security.InsecureExactSettingsRule" message="Security.exactSettings is set to an insecure value"> <description>The security.exactSettings value should remain set at the default true value. Setting this value to false could make the SWF vulnerable to cross-domain attacks.</description> <priority>1</priority> @@ -37,7 +37,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.security.AllowAllSecureDomainRule" + <rule class="org.apache.flex.pmd.rules.security.AllowAllSecureDomainRule" message="Security.allowDomain is set to an insecure value"> <description>The security.allowDomain value of "*" will allow any domain to cross-script into the domain of this SWF and exercise its functionality.</description> <priority>1</priority> @@ -47,7 +47,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.security.LocalConnectionStarRule" + <rule class="org.apache.flex.pmd.rules.security.LocalConnectionStarRule" message="LocalConnection.allowDomain is set to an insecure value"> <description>The LocalConnection.allowDomain value of "*" will allow any domain to connect to this SWF and call its functions.</description> <priority>1</priority> @@ -57,7 +57,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.security.AllowInsecureDomainRule" + <rule class="org.apache.flex.pmd.rules.security.AllowInsecureDomainRule" message="Potentially unnecessary use of allowInsecureDomain"> <description>Using allowInsecureDomain will allow untrusted content from an HTTP site to inject data into a trusted HTTPS connection which may comprimise the integrity of the HTTPS connection. The use of allowDomain is preferred.</description> <priority>1</priority> @@ -68,7 +68,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.security.LSOSecureFalseRule" + <rule class="org.apache.flex.pmd.rules.security.LSOSecureFalseRule" message="The secure flag is set to false"> <description>If this SWF is being served over HTTPS then the secure flag should be set to true. This can help prevent sensitive SSL protected information from being shared within insecure HTTP content. If this SWF is served over HTTP then you can ignore this warning.</description> <priority>5</priority> @@ -78,7 +78,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.security.ImportLoadBestPracticeRule" + <rule class="org.apache.flex.pmd.rules.security.ImportLoadBestPracticeRule" message="Set allowCodeImport to false when import loading images"> <description>If this loader is only intended to load image files (GIF,JPG,PNG) then be sure to set the allowCodeImport value to false. Setting this flag will reduce the chances of an untrusted SWF gaining access to your site. If your intent is to load a SWF, the URL for the request is a static value for a trusted site and/or you have already set the allowCodeImport flag, then you can ignore this warning.</description> <priority>5</priority> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/sizing.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/sizing.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/sizing.xml index f2030bf..a16472c 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/sizing.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/sizing.xml @@ -27,7 +27,7 @@ The Sizing As3 Ruleset contains a collection of good practices related to code sizing. </description> - <rule class="com.adobe.ac.pmd.rules.sizing.TooManyFunctionRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooManyFunctionRule" message="Too many methods detected ({0} maximum, but {1} actually)"> <description>A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.</description> <priority>3</priority> @@ -47,7 +47,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooLongFunctionRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooLongFunctionRule" message="This function is far too long ({0} maximum, but {1} actually)"> <description>Violations of this rule usually indicate that the method has too much responsibility. Try to reduce the method size by creating helper methods and removing any copy/pasted code.</description> <priority>3</priority> @@ -69,7 +69,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooLongSwitchCaseRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooLongSwitchCaseRule" message="Long switch case detected ({0} lines maximum, but {1} actually)"> <description>A switch case statement should be either empty, or contain a break, or call another method.</description> <priority>3</priority> @@ -101,7 +101,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooManyParametersRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooManyParametersRule" message="Long parameter list detected ({0} maximum, but {1} actually)"> <description>Long parameter lists can indicate that a new object should be created to wrap the numerous parameters. Basically, try to group the parameters together. </description> @@ -122,7 +122,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooManyPublicRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooManyPublicRule" message="Too many public fields or functions detected ({0} maximum, but {1} actually)"> <description>A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.</description> <priority>3</priority> @@ -149,7 +149,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooManyFieldsRule" + <rule class="org.apache.flex.pmd.rules.sizing.TooManyFieldsRule" message="Too many field detected ({0} maximum, but {1} actually)"> <description>Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zipcode fields could instead have one Address field.</description> <priority>3</priority> @@ -171,7 +171,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.sizing.TooManyFieldInVORule" + <rule class="org.apache.flex.pmd.rules.sizing.TooManyFieldInVORule" message="Too many field detected ({0} maximum, but {1} actually)"> <priority>3</priority> </rule> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/style.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/style.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/style.xml index e60c32c..2d85123 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/style.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/style.xml @@ -27,7 +27,7 @@ The Architecture ruleset contains a collection of good practices around architecture. </description> - <rule class="com.adobe.ac.pmd.rules.style.ConstructorNonEmptyReturnTypeRule" + <rule class="org.apache.flex.pmd.rules.style.ConstructorNonEmptyReturnTypeRule" message="A constructor should not have a return type"> <description>Even if this is syntactically correct, there should not be a return type for a constructor.</description> <priority>5</priority> @@ -41,7 +41,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.style.OverLongLineRule" + <rule class="org.apache.flex.pmd.rules.style.OverLongLineRule" message="Too long line ({0} maximum, but {1} actually)"> <description></description> <priority>5</priority> @@ -54,7 +54,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.style.ImportFromSamePackageRule" + <rule class="org.apache.flex.pmd.rules.style.ImportFromSamePackageRule" message="Imports from the same package are not necessary"> <description></description> <priority>5</priority> @@ -71,12 +71,12 @@ package com.adobe.ac </example> </rule> - <rule class="com.adobe.ac.pmd.rules.style.CopyrightMissingRule" + <rule class="org.apache.flex.pmd.rules.style.CopyrightMissingRule" message="The copyright header is missing in this file"> <priority>5</priority> </rule> - <rule class="com.adobe.ac.pmd.rules.style.BadFormatLoggerRule" + <rule class="org.apache.flex.pmd.rules.style.BadFormatLoggerRule" message="The logger is not correctly formatted because {0}"> <description></description> <priority>5</priority> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/switches.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/switches.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/switches.xml index ea8514f..4fc4d79 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/switches.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/switches.xml @@ -28,7 +28,7 @@ </description> <rule - class="com.adobe.ac.pmd.rules.switchrules.SwitchStatementsShouldHaveDefaultRule" + class="org.apache.flex.pmd.rules.switchrules.SwitchStatementsShouldHaveDefaultRule" message="A switch statement does not contain a default statement"> <description>Switch statements should have a default label in order to detect corner cases.</description> <priority>1</priority> @@ -47,7 +47,7 @@ public class Foo </example> </rule> - <rule class="com.adobe.ac.pmd.rules.switchrules.NestedSwitchRule" + <rule class="org.apache.flex.pmd.rules.switchrules.NestedSwitchRule" message="Switch must not be nested"> <description>As a general practice, switch statement should not be used. Prefer using inheritance. It is even harder to read when switch statements are nested.</description> <priority>3</priority> @@ -72,7 +72,7 @@ public function foo( a : Number, b : Number ) : void </example> </rule> - <rule class="com.adobe.ac.pmd.rules.switchrules.NonBreakableSwitchCaseRule" + <rule class="org.apache.flex.pmd.rules.switchrules.NonBreakableSwitchCaseRule" message="Switch case must include break statement"> <priority>1</priority> <example> @@ -91,7 +91,7 @@ switch(event.type){ <rule - class="com.adobe.ac.pmd.rules.switchrules.TooFewBrancheInSwitchStatementRule" + class="org.apache.flex.pmd.rules.switchrules.TooFewBrancheInSwitchStatementRule" message="There are too few branches in this switch statement ({0} minimum, but {1} actual)"> <description>Switch statements are designed for complex branches, and allow branches to share treatment. Using a switch for only 2 branches is ill advised, as switches are not as easy to understand as if. In this case, it's most likely is a good idea to use a if statement</description> <priority>5</priority> @@ -104,7 +104,7 @@ switch(event.type){ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.switchrules.IdenticalSwitchCasesRule" + <rule class="org.apache.flex.pmd.rules.switchrules.IdenticalSwitchCasesRule" message="Two switch cases should not be identical"> <priority>1</priority> </rule> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/unused.xml ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/unused.xml b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/unused.xml index ed8fba2..02a5ab6 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/unused.xml +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/main/resources/rulesets/flex/unused.xml @@ -27,7 +27,7 @@ The Architecture ruleset contains a collection of good practices around architecture. </description> - <rule class="com.adobe.ac.pmd.rules.unused.UnusedParameterRule" + <rule class="org.apache.flex.pmd.rules.unused.UnusedParameterRule" message="This parameter ({0}) of this function is not used"> <description> </description> @@ -40,7 +40,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.unused.UnusedLocalVariableRule" + <rule class="org.apache.flex.pmd.rules.unused.UnusedLocalVariableRule" message="This variable ({0}) is not used"> <description> </description> @@ -53,7 +53,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.unused.UnusedPrivateMethodRule" + <rule class="org.apache.flex.pmd.rules.unused.UnusedPrivateMethodRule" message="This private method ({0}) does not seem to be used"> <description> </description> @@ -62,7 +62,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.unused.UnusedFieldRule" + <rule class="org.apache.flex.pmd.rules.unused.UnusedFieldRule" message="This private attribute ({0}) does not seem to be used"> <description> </description> @@ -71,7 +71,7 @@ </example> </rule> - <rule class="com.adobe.ac.pmd.rules.unused.EmptyPrivateMethodRule" + <rule class="org.apache.flex.pmd.rules.unused.EmptyPrivateMethodRule" message="This private method ({0}) is used but its content is empty"> <description> </description> http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractFlexRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractFlexRuleTest.java b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractFlexRuleTest.java index 7875bbd..0564fdb 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractFlexRuleTest.java +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractFlexRuleTest.java @@ -16,11 +16,13 @@ */ package org.apache.flex.pmd.rules; +import static org.junit.Assert.*; + import org.apache.flex.pmd.files.IFlexFile; import org.apache.flex.pmd.parser.exceptions.TokenException; import org.apache.flex.pmd.rules.core.AbstractFlexRule; import org.apache.flex.pmd.rules.core.ViolationPosition; -import org.testng.annotations.Test; +import org.junit.Test; import java.io.IOException; import java.util.ArrayList; @@ -28,9 +30,6 @@ import java.util.LinkedHashMap; import java.util.List; import java.util.Map; -import static org.testng.Assert.assertEquals; -import static org.testng.Assert.fail; - public abstract class AbstractFlexRuleTest extends FlexPmdTestBase { final static class AssertPosition { public static AssertPosition create(final String message, @@ -172,8 +171,8 @@ public abstract class AbstractFlexRuleTest extends FlexPmdTestBase { try { final List<IFlexViolation> violations = processFile(resourcePath); - assertEquals(violations.size(), expectedPositions.length, - VIOLATIONS_NUMBER_NOT_CORRECT + " for " + resourcePath); + assertEquals(VIOLATIONS_NUMBER_NOT_CORRECT + " for " + resourcePath, + violations.size(), expectedPositions.length); if (expectedPositions.length != 0) { printFailures(buildFailureViolations(resourcePath, http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractRegExpBasedRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractRegExpBasedRuleTest.java b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractRegExpBasedRuleTest.java index 38afe1a..1589d92 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractRegExpBasedRuleTest.java +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/AbstractRegExpBasedRuleTest.java @@ -16,10 +16,11 @@ */ package org.apache.flex.pmd.rules; +import static org.junit.Assert.*; + import org.apache.flex.pmd.rules.core.AbstractFlexRule; import org.apache.flex.pmd.rules.core.AbstractRegexpBasedRule; -import org.testng.Assert; -import org.testng.annotations.Test; +import org.junit.Test; public abstract class AbstractRegExpBasedRuleTest extends AbstractFlexRuleTest { @Test @@ -27,13 +28,13 @@ public abstract class AbstractRegExpBasedRuleTest extends AbstractFlexRuleTest { final AbstractRegexpBasedRule rule = getRegexpBasedRule(); if (getMatchableLines().length == 0) { - Assert.fail("the getMatchableLines() is empty"); + fail("the getMatchableLines() is empty"); } for (int i = 0; i < getMatchableLines().length; i++) { final String correctLine = getMatchableLines()[i]; - Assert.assertTrue(rule.doesCurrentLineMacthes(correctLine), - "This line (\"" + correctLine + "\") should be matched"); + assertTrue("This line (\"" + correctLine + "\") should be matched", + rule.doesCurrentLineMacthes(correctLine)); } } @@ -42,13 +43,13 @@ public abstract class AbstractRegExpBasedRuleTest extends AbstractFlexRuleTest { final AbstractRegexpBasedRule rule = getRegexpBasedRule(); if (getUnmatchableLines().length == 0) { - Assert.fail("the getUnmatchableLines() is empty"); + fail("the getUnmatchableLines() is empty"); } for (int i = 0; i < getUnmatchableLines().length; i++) { final String incorrectLine = getUnmatchableLines()[i]; - Assert.assertFalse(rule.doesCurrentLineMacthes(incorrectLine), - "This line (\"" + incorrectLine + "\") should not be matched"); + assertFalse("This line (\"" + incorrectLine + "\") should not be matched", + rule.doesCurrentLineMacthes(incorrectLine)); } } http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/performance/BindableClassRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/performance/BindableClassRuleTest.java b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/performance/BindableClassRuleTest.java index 2c833b9..355f87c 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/performance/BindableClassRuleTest.java +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/performance/BindableClassRuleTest.java @@ -19,7 +19,7 @@ package org.apache.flex.pmd.rules.performance; import org.apache.flex.pmd.rules.AbstractAstFlexRuleTest; import org.apache.flex.pmd.rules.core.AbstractFlexRule; import org.apache.flex.pmd.rules.core.ViolationPosition; -import org.testng.annotations.Test; +import org.junit.Test; // This test requires test-data that was not donated to Apache public class BindableClassRuleTest /*extends AbstractAstFlexRuleTest*/ { http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedLocalVariableRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedLocalVariableRuleTest.java b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedLocalVariableRuleTest.java index 32e1c1d..202ca47 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedLocalVariableRuleTest.java +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedLocalVariableRuleTest.java @@ -19,7 +19,7 @@ package org.apache.flex.pmd.rules.unused; import org.apache.flex.pmd.rules.AbstractAstFlexRuleTest; import org.apache.flex.pmd.rules.core.AbstractFlexRule; import org.apache.flex.pmd.rules.core.ViolationPosition; -import org.testng.annotations.Test; +import org.junit.Test; // This test requires test-data that was not donated to Apache public class UnusedLocalVariableRuleTest /*extends AbstractAstFlexRuleTest*/ { http://git-wip-us.apache.org/repos/asf/flex-utilities/blob/526c1e73/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedParameterRuleTest.java ---------------------------------------------------------------------- diff --git a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedParameterRuleTest.java b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedParameterRuleTest.java index 82edad5..1802e8a 100644 --- a/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedParameterRuleTest.java +++ b/FlexPMD/language-module/ruleset/ruleset-flex-basic/src/test/java/org/apache/flex/pmd/rules/unused/UnusedParameterRuleTest.java @@ -19,7 +19,7 @@ package org.apache.flex.pmd.rules.unused; import org.apache.flex.pmd.rules.AbstractAstFlexRuleTest; import org.apache.flex.pmd.rules.core.AbstractFlexRule; import org.apache.flex.pmd.rules.core.ViolationPosition; -import org.testng.annotations.Test; +import org.junit.Test; import java.util.LinkedHashMap;
