Repository: flex-sdk Updated Branches: refs/heads/develop f14f5f8ae -> b709fd13a
FLEX-34854 FLEX-34884 Now testing spark.collections.Sort(Field) instead of the mx versions because the findItem() function is the same (defined in the mx.collections.Sort(Field) classes), so if the spark versions work well, it's very likely that the mx versions also do. (This is to avoid having to copy-paste all the tests for the spark and mx versions of the sort classes, which would be unmaintainable.) Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f46e3081 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f46e3081 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f46e3081 Branch: refs/heads/develop Commit: f46e308146cb572ffcb4b61b59f692a5c1dd0119 Parents: f14f5f8 Author: Mihai Chira <[email protected]> Authored: Thu Jul 16 20:48:08 2015 +0200 Committer: Mihai Chira <[email protected]> Committed: Thu Jul 16 20:48:08 2015 +0200 ---------------------------------------------------------------------- frameworks/projects/framework/tests/FLEX_34884_Tests.as | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f46e3081/frameworks/projects/framework/tests/FLEX_34884_Tests.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/framework/tests/FLEX_34884_Tests.as b/frameworks/projects/framework/tests/FLEX_34884_Tests.as index 7bfe80c..c1bea32 100644 --- a/frameworks/projects/framework/tests/FLEX_34884_Tests.as +++ b/frameworks/projects/framework/tests/FLEX_34884_Tests.as @@ -23,8 +23,8 @@ package { import mx.collections.ComplexSortField; import mx.collections.IList; import mx.collections.ListCollectionView; - import mx.collections.Sort; - import mx.collections.SortField; + import spark.collections.Sort; + import spark.collections.SortField; import org.flexunit.assertThat; @@ -58,7 +58,7 @@ package { _sut.addAll(from0To4); //values: Object0, Object1, Object2, Object3, Object4 const sortByIndexAscending:Sort = new Sort(); - sortByIndexAscending.fields = [new SortField("index", false, false, true)]; + sortByIndexAscending.fields = [new SortField("index", false, true)]; _sut.sort = sortByIndexAscending; _sut.refresh(); //values (unchanged): Object0, Object1, Object2, Object3, Object4 @@ -78,7 +78,7 @@ package { _sut.addAll(from0To4); //values: Object0, Object1, Object2, Object3, Object4 const sortByIndexDescending:Sort = new Sort(); - sortByIndexDescending.fields = [new SortField("index", false, true, true)]; + sortByIndexDescending.fields = [new SortField("index", true, true)]; _sut.sort = sortByIndexDescending; _sut.refresh(); //values: Object4, Object3, Object2, Object1, Object0 @@ -98,7 +98,7 @@ package { _sut.addAll(from0To4); //values: Object0, Object1, Object2, Object3, Object4 const sortByIndexDescending:Sort = new Sort(); - sortByIndexDescending.fields = [new SortField("index", false, true, true)]; + sortByIndexDescending.fields = [new SortField("index", true, true)]; _sut.sort = sortByIndexDescending; _sut.refresh(); //values: Object4, Object3, Object2, Object1, Object0 @@ -212,7 +212,7 @@ package { _sut.addAll(from0To4); //values[address.street]: Street0, Street1, Street2, Street3, Street4 const sortByIndexAscending:Sort = new Sort(); - sortByIndexAscending.fields = [new ComplexSortField("address.street", false, false, false)]; + sortByIndexAscending.fields = [new ComplexSortField("address.street", false, false)]; _sut.sort = sortByIndexAscending; _sut.refresh(); //values[address.street] (unchanged): Street0, Street1, Street2, Street3, Street4
