fix panel chrome calculations. We should probably introduce an Offsets class that doesn't have width/height properties that interact with left/right/top/bottom
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4906f08a Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4906f08a Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4906f08a Branch: refs/heads/develop Commit: 4906f08a257b922791b112b0ba3018e48f8faa5d Parents: 81082b0 Author: Alex Harui <[email protected]> Authored: Thu Sep 3 12:09:33 2015 -0700 Committer: Alex Harui <[email protected]> Committed: Thu Sep 3 15:23:39 2015 -0700 ---------------------------------------------------------------------- .../projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as | 2 +- .../as/src/org/apache/flex/html/beads/PanelWithControlBarView.as | 2 +- .../projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4906f08a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as index fbd22ac..aaa06eb 100644 --- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as +++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelView.as @@ -127,7 +127,7 @@ package org.apache.flex.html.beads */ override protected function getChromeMetrics():Rectangle { - return new Rectangle(0, titleBar.height, 0, 0); + return new Rectangle(0, titleBar.height, 0, 0 - titleBar.height); } override protected function layoutViewBeforeContentLayout():void http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4906f08a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelWithControlBarView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelWithControlBarView.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelWithControlBarView.as index c0c7c02..e513963 100644 --- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelWithControlBarView.as +++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/PanelWithControlBarView.as @@ -150,7 +150,7 @@ package org.apache.flex.html.beads */ override protected function getChromeMetrics():Rectangle { - return new Rectangle(0, titleBar.height, 0, titleBar.height + controlBar.height); + return new Rectangle(0, titleBar.height, 0, controlBar.height - titleBar.height); } override protected function layoutViewBeforeContentLayout():void http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4906f08a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js index 10a76f3..4ee79ed 100644 --- a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js +++ b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js @@ -153,7 +153,7 @@ org.apache.flex.html.beads.PanelView. */ org.apache.flex.html.beads.PanelView. prototype.getChromeMetrics = function() { - return new org.apache.flex.geom.Rectangle(0, this.titleBar.height, 0, 0); + return new org.apache.flex.geom.Rectangle(0, this.titleBar.height, 0, 0 - this.titleBar.height); };
