Set itemRenderers to full width of the "column" and leave height alone; grid lines will have to be achieved through other means, such as beads.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/29970783 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/29970783 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/29970783 Branch: refs/heads/master Commit: 29970783852014e5a17f1f609c008009108bede5 Parents: 848f245 Author: Peter Ent <[email protected]> Authored: Thu Oct 8 15:25:12 2015 -0400 Committer: Peter Ent <[email protected]> Committed: Thu Oct 8 15:25:12 2015 -0400 ---------------------------------------------------------------------- .../src/org/apache/flex/core/ItemRendererClassFactory.as | 1 - .../src/org/apache/flex/core/ItemRendererClassFactory.js | 1 - frameworks/projects/HTML/as/defaults.css | 4 +--- .../HTML/as/src/org/apache/flex/html/beads/ListView.as | 1 - .../asjs/src/org/apache/flex/html/beads/DataGridView.as | 10 +++++----- .../html/beads/DataItemRendererFactoryForArrayList.as | 7 +++++-- 6 files changed, 11 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/Core/as/src/org/apache/flex/core/ItemRendererClassFactory.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Core/as/src/org/apache/flex/core/ItemRendererClassFactory.as b/frameworks/projects/Core/as/src/org/apache/flex/core/ItemRendererClassFactory.as index b2a7ef3..b3875e7 100644 --- a/frameworks/projects/Core/as/src/org/apache/flex/core/ItemRendererClassFactory.as +++ b/frameworks/projects/Core/as/src/org/apache/flex/core/ItemRendererClassFactory.as @@ -175,7 +175,6 @@ package org.apache.flex.core { var renderer:IItemRenderer = itemRendererFactory.newInstance(); renderer.itemRendererParent = parent; - parent.addElement(renderer); return renderer; } http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/Core/js/src/org/apache/flex/core/ItemRendererClassFactory.js ---------------------------------------------------------------------- diff --git a/frameworks/projects/Core/js/src/org/apache/flex/core/ItemRendererClassFactory.js b/frameworks/projects/Core/js/src/org/apache/flex/core/ItemRendererClassFactory.js index a5f8c5f..9d3ca0d 100644 --- a/frameworks/projects/Core/js/src/org/apache/flex/core/ItemRendererClassFactory.js +++ b/frameworks/projects/Core/js/src/org/apache/flex/core/ItemRendererClassFactory.js @@ -92,6 +92,5 @@ org.apache.flex.core.ItemRendererClassFactory. org.apache.flex.core.ItemRendererClassFactory. prototype.createFromClass = function(parent) { var renderer = this.itemRendererClassFactory.newInstance(); - parent.addElement(renderer); return renderer; }; http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/HTML/as/defaults.css ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/as/defaults.css b/frameworks/projects/HTML/as/defaults.css index 1a61438..db0145c 100644 --- a/frameworks/projects/HTML/as/defaults.css +++ b/frameworks/projects/HTML/as/defaults.css @@ -104,8 +104,6 @@ DataGrid IDataGridPresentationModel: ClassReference("org.apache.flex.html.beads.models.DataGridPresentationModel"); IBeadView: ClassReference("org.apache.flex.html.beads.DataGridView"); IBeadModel: ClassReference("org.apache.flex.html.beads.models.DataGridModel"); - IItemRendererClassFactory: ClassReference("org.apache.flex.core.ItemRendererClassFactory"); - IItemRenderer: ClassReference("org.apache.flex.html.supportClasses.StringItemRenderer"); background-color: #FFFFFF; border-style: solid; @@ -129,7 +127,7 @@ DataGrid } .DataGridListArea { - background-color: #AAAAAA; + background-color: #FFFFFF; border-style: solid; border-color: #333333; } http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ListView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ListView.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ListView.as index a9192f4..a38afec 100644 --- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ListView.as +++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ListView.as @@ -205,7 +205,6 @@ package org.apache.flex.html.beads override protected function resizeHandler(event:Event):void { super.resizeHandler(event); - dataGroup.updateAllItemRenderers(); } } } http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataGridView.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataGridView.as b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataGridView.as index 43c410f..7f220e9 100644 --- a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataGridView.as +++ b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataGridView.as @@ -188,10 +188,10 @@ package org.apache.flex.html.beads var dataGridColumn:DataGridColumn = sharedModel.columns[i] as DataGridColumn; var colWidth:Number = dataGridColumn.columnWidth; - if (!isNaN(colWidth)) list.width = colWidth - 1; - else list.width = listWidth - 1; + if (!isNaN(colWidth)) list.width = colWidth; + else list.width = listWidth; - xpos += list.width + 1; + xpos += list.width; } } } @@ -293,8 +293,8 @@ package org.apache.flex.html.beads list.addBead(presentationModel); var colWidth:Number = dataGridColumn.columnWidth; - if (!isNaN(colWidth)) list.width = colWidth - 1; - else list.width = listWidth - 1; + if (!isNaN(colWidth)) list.width = colWidth; + else list.width = listWidth; _listArea.addElement(list); _lists.push(list); http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/29970783/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataItemRendererFactoryForArrayList.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataItemRendererFactoryForArrayList.as b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataItemRendererFactoryForArrayList.as index f2c4ae7..9895394 100644 --- a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataItemRendererFactoryForArrayList.as +++ b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/beads/DataItemRendererFactoryForArrayList.as @@ -156,10 +156,13 @@ package org.apache.flex.html.beads ir.index = i; ir.labelField = labelField; if (presentationModel) { + UIBase(ir).height = presentationModel.rowHeight; + + // ensure that the IR spans the width of its column var style:SimpleCSSStyles = new SimpleCSSStyles(); - style.marginBottom = presentationModel.separatorThickness; + style.right = 0; + style.left = 0; UIBase(ir).style = style; - UIBase(ir).height = presentationModel.rowHeight; } dataGroup.addElement(ir); ir.data = dp.getItemAt(i);
