Repository: flex-falcon Updated Branches: refs/heads/develop 263918bfe -> ad9e1127f
FLEX-35107 update comment, actual fix in 263918bfe12d8369523644f2c26d1f00fb8aab99 Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/ad9e1127 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/ad9e1127 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/ad9e1127 Branch: refs/heads/develop Commit: ad9e1127faf8b37dea8e09020895726d68636f2c Parents: 263918b Author: Alex Harui <[email protected]> Authored: Mon Jul 11 23:18:41 2016 -0700 Committer: Alex Harui <[email protected]> Committed: Mon Jul 11 23:18:41 2016 -0700 ---------------------------------------------------------------------- .../compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/ad9e1127/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java ---------------------------------------------------------------------- diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java index 2c06fef..f383ae0 100644 --- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java +++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java @@ -896,7 +896,9 @@ public class JSFlexJSEmitter extends JSGoogEmitter implements IJSFlexJSEmitter * We want to know not just whether the node is of type XML, * but whether it is a property of a property of type XML. * For example, this.foo might be XML or XMLList, but since - * 'this' isn't also XML, we return false. + * 'this' isn't also XML, we return false. That's because + * assignment to this.foo shouldn't use setChild() but + * just do an assignment. * @param obj * @return */
