Upload some comments to Dialog.as to show HTMLDialogElement method calling 
problems


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/d2080d36
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/d2080d36
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/d2080d36

Branch: refs/heads/feature/mdl
Commit: d2080d3626cbd61ff8b132fb7bd8a5824b3441cc
Parents: 50cb026
Author: Carlos Rovira <[email protected]>
Authored: Fri Jan 20 18:35:41 2017 +0100
Committer: Carlos Rovira <[email protected]>
Committed: Fri Jan 20 18:35:41 2017 +0100

----------------------------------------------------------------------
 .../src/main/flex/org/apache/flex/mdl/Dialog.as              | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/d2080d36/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Dialog.as
----------------------------------------------------------------------
diff --git 
a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Dialog.as
 
b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Dialog.as
index 2fa23eb..33d986a 100644
--- 
a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Dialog.as
+++ 
b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/Dialog.as
@@ -58,7 +58,7 @@ package org.apache.flex.mdl
                }
 
                COMPILE::JS
-               private var dialog:HTMLElement;
+               private var dialog:HTMLElement; //HTMLDialogElement
 
         /**
          * @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
@@ -115,7 +115,7 @@ package org.apache.flex.mdl
                                        }
                                }
                                
-                               dialog["showModal"]();
+                               dialog["showModal"](); //dialog.showModal()
                        }
                }
                
@@ -126,7 +126,7 @@ package org.apache.flex.mdl
                {
                        COMPILE::JS
                        {
-                               dialog["show"]();//dialog.show();
+                               dialog["show"](); //dialog.show();
                        }
                }
 
@@ -137,7 +137,7 @@ package org.apache.flex.mdl
                {
                        COMPILE::JS
                        {
-                               dialog["close"]();//dialog.close();
+                               dialog["close"](); //dialog.close();
                        }
                }
        }

Reply via email to