FLEX-35260 GridHeaderViewLayout.getHeaderIndexAt() (which calls GridDimensions.getColumnIndexAt()) used to return a valid headerIndex (when it was expected to return -1) for an x < 0. Fixed.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/2adccce7 Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/2adccce7 Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/2adccce7 Branch: refs/heads/develop Commit: 2adccce7c285cbbdbd4ceda3e5267d0434fbd477 Parents: ad48251 Author: Mihai Chira <mih...@apache.org> Authored: Fri Mar 10 17:53:45 2017 +0100 Committer: Mihai Chira <mih...@apache.org> Committed: Fri Mar 10 17:53:45 2017 +0100 ---------------------------------------------------------------------- .../src/spark/components/gridClasses/GridDimensions.as | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/2adccce7/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as index ec0a003..0c679db 100644 --- a/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as +++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridDimensions.as @@ -1183,9 +1183,12 @@ public class GridDimensions */ public function getColumnIndexAt(x:Number, y:Number):int { - var cur:Number = x; + var current:Number = x; var i:int; - + + if(current < 0) + return -1; + for (i = 0; i < _columnCount; i++) { var temp:Number = _columnWidths[i]; @@ -1202,9 +1205,9 @@ public class GridDimensions if (isNaN(temp)) temp = defaultColumnWidth; - cur -= temp + columnGap; + current -= temp + columnGap; - if (cur < 0) + if (current < 0) return i; }