[FLINK-5171] [runtime] fix wrong use of Preconditions.checkState in 
TaskManagerRunner

This closes #2880.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/b58c6dcb
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/b58c6dcb
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/b58c6dcb

Branch: refs/heads/master
Commit: b58c6dcb820b7434fbec206820c57845c06d84d6
Parents: 006a19d
Author: shuai.xus <[email protected]>
Authored: Mon Nov 28 17:21:26 2016 +0800
Committer: Stephan Ewen <[email protected]>
Committed: Fri Dec 23 20:54:25 2016 +0100

----------------------------------------------------------------------
 .../org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/b58c6dcb/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
----------------------------------------------------------------------
diff --git 
a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 
b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
index 99a7c5d..a18ff40 100644
--- 
a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
+++ 
b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
@@ -185,7 +185,7 @@ public class TaskManagerRunner implements FatalErrorHandler 
{
 
                final int rpcPort = 
configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
 
-               Preconditions.checkState(rpcPort < 0 || rpcPort >65535, 
"Invalid value for " +
+               Preconditions.checkState(rpcPort >= 0 && rpcPort <= 65535, 
"Invalid value for " +
                                "'%s' (port for the TaskManager actor system) : 
%d - Leave config parameter empty or " +
                                "use 0 to let the system choose port 
automatically.",
                        ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, rpcPort);

Reply via email to