Repository: flink Updated Branches: refs/heads/master 124872319 -> a30355356
[hotfix] Harden TaskExecutorTest#testHeartbeatTimeoutWithJobManager by increasing timeout In order to check whether the heartbeat manager detects timeouts we wait on the JobMasterGateway.disconnectTaskManager call which happens asynchronously. In order to harden the test, we increase the timeout from 50 ms to 500 ms for the timeout call to happen. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/a3035535 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/a3035535 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/a3035535 Branch: refs/heads/master Commit: a303553560fc8c3653a0eb29400566a3c6c7ed3e Parents: 1248723 Author: Till Rohrmann <[email protected]> Authored: Mon Mar 20 18:41:07 2017 +0100 Committer: Till Rohrmann <[email protected]> Committed: Mon Mar 20 18:43:14 2017 +0100 ---------------------------------------------------------------------- .../org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/a3035535/flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java index 0f5bad3..12ec69d 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java @@ -199,7 +199,7 @@ public class TaskExecutorTest extends TestLogger { eq(taskManager.getAddress()), eq(taskManagerLocation), eq(jmLeaderId), any(Time.class)); // the timeout should trigger disconnecting from the JobManager - verify(jobMasterGateway, timeout(heartbeatTimeout * 5)).disconnectTaskManager(eq(taskManagerLocation.getResourceID()), any(TimeoutException.class)); + verify(jobMasterGateway, timeout(heartbeatTimeout * 50L)).disconnectTaskManager(eq(taskManagerLocation.getResourceID()), any(TimeoutException.class)); // check if a concurrent error occurred testingFatalErrorHandler.rethrowError();
