Repository: flink
Updated Branches:
  refs/heads/release-1.2 ef20aa1a1 -> c0fb70f1c


[FLINK-6398] RowSerializer's duplicate should always return a new instance

This closes #3794.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/c0fb70f1
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/c0fb70f1
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/c0fb70f1

Branch: refs/heads/release-1.2
Commit: c0fb70f1c46fda6736943cd836884be72d29781b
Parents: ef20aa1
Author: Kurt Young <[email protected]>
Authored: Thu Apr 27 23:37:21 2017 +0800
Committer: Kurt Young <[email protected]>
Committed: Fri Apr 28 22:43:42 2017 +0800

----------------------------------------------------------------------
 .../api/java/typeutils/runtime/RowSerializer.java      | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/c0fb70f1/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
----------------------------------------------------------------------
diff --git 
a/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
 
b/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
index 827c2fa..dbd5d3a 100644
--- 
a/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
+++ 
b/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
@@ -53,22 +53,11 @@ public class RowSerializer extends TypeSerializer<Row> {
 
        @Override
        public TypeSerializer<Row> duplicate() {
-               boolean stateful = false;
                TypeSerializer<?>[] duplicateFieldSerializers = new 
TypeSerializer[fieldSerializers.length];
-
                for (int i = 0; i < fieldSerializers.length; i++) {
                        duplicateFieldSerializers[i] = 
fieldSerializers[i].duplicate();
-                       if (duplicateFieldSerializers[i] != 
fieldSerializers[i]) {
-                               // at least one of them is stateful
-                               stateful = true;
-                       }
-               }
-
-               if (stateful) {
-                       return new RowSerializer(duplicateFieldSerializers);
-               } else {
-                       return this;
                }
+               return new RowSerializer(duplicateFieldSerializers);
        }
 
        @Override

Reply via email to