[FLINK-6729] Activate checkstyle in runtime/accumulators
Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/fa11845b Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/fa11845b Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/fa11845b Branch: refs/heads/master Commit: fa11845b926f8371e9cee47775ca0e48176b686e Parents: 16115f9 Author: zentol <[email protected]> Authored: Wed May 31 15:40:34 2017 +0200 Committer: zentol <[email protected]> Committed: Thu Jun 1 11:16:42 2017 +0200 ---------------------------------------------------------------------- flink-runtime/pom.xml | 1 - .../flink/runtime/accumulators/AccumulatorRegistry.java | 1 + .../runtime/accumulators/StringifiedAccumulatorResult.java | 8 ++++---- .../accumulators/StringifiedAccumulatorResultTest.java | 5 ++++- 4 files changed, 9 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/fa11845b/flink-runtime/pom.xml ---------------------------------------------------------------------- diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml index b7def4d..2272bc7 100644 --- a/flink-runtime/pom.xml +++ b/flink-runtime/pom.xml @@ -425,7 +425,6 @@ under the License. **/migration/state/**, **/migration/streaming/**, **/migration/*, - **/runtime/accumulators/**, **/runtime/akka/**, **/runtime/blob/**, **/runtime/broadcast/**, http://git-wip-us.apache.org/repos/asf/flink/blob/fa11845b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java index ce6cb1b..e1721d9 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java @@ -21,6 +21,7 @@ package org.apache.flink.runtime.accumulators; import org.apache.flink.api.common.JobID; import org.apache.flink.api.common.accumulators.Accumulator; import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; + import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/fa11845b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java index c4faad1..b55159c 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java @@ -50,13 +50,13 @@ public class StringifiedAccumulatorResult implements java.io.Serializable{ public String getValue() { return value; } - + // ------------------------------------------------------------------------ // Utilities // ------------------------------------------------------------------------ /** - * Flatten a map of accumulator names to Accumulator instances into an array of StringifiedAccumulatorResult values + * Flatten a map of accumulator names to Accumulator instances into an array of StringifiedAccumulatorResult values. */ public static StringifiedAccumulatorResult[] stringifyAccumulatorResults(Map<String, Accumulator<?, ?>> accs) { if (accs == null || accs.isEmpty()) { @@ -64,7 +64,7 @@ public class StringifiedAccumulatorResult implements java.io.Serializable{ } else { StringifiedAccumulatorResult[] results = new StringifiedAccumulatorResult[accs.size()]; - + int i = 0; for (Map.Entry<String, Accumulator<?, ?>> entry : accs.entrySet()) { StringifiedAccumulatorResult result; @@ -79,7 +79,7 @@ public class StringifiedAccumulatorResult implements java.io.Serializable{ } else { result = new StringifiedAccumulatorResult(entry.getKey(), "null", "null"); } - + results[i++] = result; } return results; http://git-wip-us.apache.org/repos/asf/flink/blob/fa11845b/flink-runtime/src/test/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResultTest.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResultTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResultTest.java index e6d637b..65c4b7a 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResultTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResultTest.java @@ -22,6 +22,7 @@ import org.apache.flink.api.common.accumulators.Accumulator; import org.apache.flink.api.common.accumulators.IntCounter; import org.apache.flink.api.common.accumulators.SimpleAccumulator; import org.apache.flink.core.testutils.CommonTestUtils; + import org.junit.Test; import java.io.IOException; @@ -31,6 +32,9 @@ import java.util.Map; import static org.junit.Assert.assertEquals; +/** + * Tests for the {@link StringifiedAccumulatorResult}. + */ public class StringifiedAccumulatorResultTest { @Test @@ -62,7 +66,6 @@ public class StringifiedAccumulatorResultTest { final Map<String, Accumulator<?, ?>> accumulatorMap = new HashMap<>(); accumulatorMap.put(name, acc); - final StringifiedAccumulatorResult[] results = StringifiedAccumulatorResult.stringifyAccumulatorResults(accumulatorMap); assertEquals(1, results.length);
