[FLINK-6794] Activate checkstyle for migration/** This closes #4038.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/00a26668 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/00a26668 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/00a26668 Branch: refs/heads/master Commit: 00a266680c8e962fb158472821e1d78660385a2e Parents: 2b3d284 Author: zentol <[email protected]> Authored: Thu Jun 1 12:33:09 2017 +0200 Committer: zentol <[email protected]> Committed: Fri Jun 2 15:13:55 2017 +0200 ---------------------------------------------------------------------- flink-runtime/pom.xml | 5 ----- .../src/main/java/org/apache/flink/migration/MigrationUtil.java | 3 +++ .../migration/streaming/runtime/tasks/StreamTaskState.java | 5 ++--- .../migration/streaming/runtime/tasks/StreamTaskStateList.java | 2 +- 4 files changed, 6 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/00a26668/flink-runtime/pom.xml ---------------------------------------------------------------------- diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml index d83d671..0f8e2e9 100644 --- a/flink-runtime/pom.xml +++ b/flink-runtime/pom.xml @@ -420,11 +420,6 @@ under the License. <logViolationsToConsole>true</logViolationsToConsole> <failOnViolation>true</failOnViolation> <excludes> - **/migration/api/**, - **/migration/runtime/**, - **/migration/state/**, - **/migration/streaming/**, - **/migration/*, **/runtime/akka/**, **/runtime/blob/**, **/runtime/broadcast/**, http://git-wip-us.apache.org/repos/asf/flink/blob/00a26668/flink-runtime/src/main/java/org/apache/flink/migration/MigrationUtil.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/migration/MigrationUtil.java b/flink-runtime/src/main/java/org/apache/flink/migration/MigrationUtil.java index a4e3a2e..a6055a8 100644 --- a/flink-runtime/src/main/java/org/apache/flink/migration/MigrationUtil.java +++ b/flink-runtime/src/main/java/org/apache/flink/migration/MigrationUtil.java @@ -23,6 +23,9 @@ import org.apache.flink.runtime.state.KeyedStateHandle; import java.util.Collection; +/** + * Utility functions for migration. + */ public class MigrationUtil { @SuppressWarnings("deprecation") http://git-wip-us.apache.org/repos/asf/flink/blob/00a26668/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskState.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskState.java b/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskState.java index 7a2aab9..b044ffb 100644 --- a/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskState.java +++ b/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskState.java @@ -36,7 +36,7 @@ import java.util.HashMap; public class StreamTaskState implements Serializable, Closeable { private static final long serialVersionUID = 1L; - + private StateHandle<?> operatorState; private StateHandle<Serializable> functionState; @@ -74,14 +74,13 @@ public class StreamTaskState implements Serializable, Closeable { /** * Checks if this state object actually contains any state, or if all of the state * fields are null. - * + * * @return True, if all state is null, false if at least one state is not null. */ public boolean isEmpty() { return operatorState == null & functionState == null & kvStates == null; } - @Override public void close() throws IOException { http://git-wip-us.apache.org/repos/asf/flink/blob/00a26668/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskStateList.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskStateList.java b/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskStateList.java index c2357f7..7643039 100644 --- a/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskStateList.java +++ b/flink-runtime/src/main/java/org/apache/flink/migration/streaming/runtime/tasks/StreamTaskStateList.java @@ -35,7 +35,7 @@ public class StreamTaskStateList implements StateHandle<StreamTaskState[]> { private static final long serialVersionUID = 1L; - /** The states for all operator */ + /** The states for all operator. */ private final StreamTaskState[] states; public StreamTaskStateList(StreamTaskState[] states) throws Exception {
