Repository: flink Updated Branches: refs/heads/master 5e6fd9d7e -> 142803f96
[FLINK-6723] Activate strict checkstyle for flink-libraries This closes #4069. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/142803f9 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/142803f9 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/142803f9 Branch: refs/heads/master Commit: 142803f960959b100a96a0458888c5d8e39c6277 Parents: 5e6fd9d Author: zentol <[email protected]> Authored: Sat Jun 3 13:31:33 2017 +0200 Committer: zentol <[email protected]> Committed: Wed Jun 7 14:35:08 2017 +0200 ---------------------------------------------------------------------- flink-libraries/flink-cep/pom.xml | 36 --------------------- flink-libraries/flink-gelly-examples/pom.xml | 35 -------------------- flink-libraries/flink-gelly/pom.xml | 39 ----------------------- flink-libraries/flink-python/pom.xml | 35 -------------------- flink-libraries/flink-table/pom.xml | 35 -------------------- flink-libraries/pom.xml | 39 +++++++++++++++++++++++ 6 files changed, 39 insertions(+), 180 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/flink-cep/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-cep/pom.xml b/flink-libraries/flink-cep/pom.xml index 6622b36..35045c0 100644 --- a/flink-libraries/flink-cep/pom.xml +++ b/flink-libraries/flink-cep/pom.xml @@ -106,42 +106,6 @@ under the License. </execution> </executions> </plugin> - - <!-- We have more strict checkstyle rules than the rest of the project --> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <dependencies> - <dependency> - <groupId>com.puppycrawl.tools</groupId> - <artifactId>checkstyle</artifactId> - <version>6.19</version> - </dependency> - </dependencies> - <configuration> - <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> - <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> - <includeTestSourceDirectory>true</includeTestSourceDirectory> - <logViolationsToConsole>true</logViolationsToConsole> - <failOnViolation>true</failOnViolation> - </configuration> - <executions> - <!-- - Execute checkstyle after compilation but before tests. - - This ensures that any parsing or type checking errors are from - javac, so they look as expected. Beyond that, we want to - fail as early as possible. - --> - <execution> - <phase>test-compile</phase> - <goals> - <goal>check</goal> - </goals> - </execution> - </executions> - </plugin> </plugins> </build> </project> http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/flink-gelly-examples/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-gelly-examples/pom.xml b/flink-libraries/flink-gelly-examples/pom.xml index 3da6263..68ad050 100644 --- a/flink-libraries/flink-gelly-examples/pom.xml +++ b/flink-libraries/flink-gelly-examples/pom.xml @@ -234,41 +234,6 @@ <configLocation>${project.basedir}/../../tools/maven/scalastyle-config.xml</configLocation> </configuration> </plugin> - - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <dependencies> - <dependency> - <groupId>com.puppycrawl.tools</groupId> - <artifactId>checkstyle</artifactId> - <version>6.19</version> - </dependency> - </dependencies> - <configuration> - <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> - <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> - <includeTestSourceDirectory>true</includeTestSourceDirectory> - <logViolationsToConsole>true</logViolationsToConsole> - <failOnViolation>true</failOnViolation> - </configuration> - <executions> - <!-- - Execute checkstyle after compilation but before tests. - - This ensures that any parsing or type checking errors are from - javac, so they look as expected. Beyond that, we want to - fail as early as possible. - --> - <execution> - <phase>test-compile</phase> - <goals> - <goal>check</goal> - </goals> - </execution> - </executions> - </plugin> </plugins> </build> http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/flink-gelly/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-gelly/pom.xml b/flink-libraries/flink-gelly/pom.xml index c059267..9c3166e 100644 --- a/flink-libraries/flink-gelly/pom.xml +++ b/flink-libraries/flink-gelly/pom.xml @@ -84,43 +84,4 @@ under the License. </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <dependencies> - <dependency> - <groupId>com.puppycrawl.tools</groupId> - <artifactId>checkstyle</artifactId> - <version>6.19</version> - </dependency> - </dependencies> - <configuration> - <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> - <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> - <includeTestSourceDirectory>true</includeTestSourceDirectory> - <logViolationsToConsole>true</logViolationsToConsole> - <failOnViolation>true</failOnViolation> - </configuration> - <executions> - <!-- - Execute checkstyle after compilation but before tests. - - This ensures that any parsing or type checking errors are from - javac, so they look as expected. Beyond that, we want to - fail as early as possible. - --> - <execution> - <phase>test-compile</phase> - <goals> - <goal>check</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> - </project> http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/flink-python/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-python/pom.xml b/flink-libraries/flink-python/pom.xml index f6cea0c..6a57c3e 100644 --- a/flink-libraries/flink-python/pom.xml +++ b/flink-libraries/flink-python/pom.xml @@ -48,41 +48,6 @@ under the License. </archive> </configuration> </plugin> - - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <dependencies> - <dependency> - <groupId>com.puppycrawl.tools</groupId> - <artifactId>checkstyle</artifactId> - <version>6.19</version> - </dependency> - </dependencies> - <configuration> - <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> - <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> - <includeTestSourceDirectory>true</includeTestSourceDirectory> - <logViolationsToConsole>true</logViolationsToConsole> - <failOnViolation>true</failOnViolation> - </configuration> - <executions> - <!-- - Execute checkstyle after compilation but before tests. - - This ensures that any parsing or type checking errors are from - javac, so they look as expected. Beyond that, we want to - fail as early as possible. - --> - <execution> - <phase>test-compile</phase> - <goals> - <goal>check</goal> - </goals> - </execution> - </executions> - </plugin> </plugins> </build> http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/flink-table/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-table/pom.xml b/flink-libraries/flink-table/pom.xml index 855a520..53b8dbb 100644 --- a/flink-libraries/flink-table/pom.xml +++ b/flink-libraries/flink-table/pom.xml @@ -250,41 +250,6 @@ under the License. <configLocation>${project.basedir}/../../tools/maven/scalastyle-config.xml</configLocation> </configuration> </plugin> - - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - <version>2.17</version> - <dependencies> - <dependency> - <groupId>com.puppycrawl.tools</groupId> - <artifactId>checkstyle</artifactId> - <version>6.19</version> - </dependency> - </dependencies> - <configuration> - <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> - <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> - <includeTestSourceDirectory>true</includeTestSourceDirectory> - <logViolationsToConsole>true</logViolationsToConsole> - <failOnViolation>true</failOnViolation> - </configuration> - <executions> - <!-- - Execute checkstyle after compilation but before tests. - - This ensures that any parsing or type checking errors are from - javac, so they look as expected. Beyond that, we want to - fail as early as possible. - --> - <execution> - <phase>test-compile</phase> - <goals> - <goal>check</goal> - </goals> - </execution> - </executions> - </plugin> </plugins> </build> </project> http://git-wip-us.apache.org/repos/asf/flink/blob/142803f9/flink-libraries/pom.xml ---------------------------------------------------------------------- diff --git a/flink-libraries/pom.xml b/flink-libraries/pom.xml index 5b4cf79..2fde26e 100644 --- a/flink-libraries/pom.xml +++ b/flink-libraries/pom.xml @@ -61,4 +61,43 @@ under the License. </dependency> </dependencies> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + <version>2.17</version> + <dependencies> + <dependency> + <groupId>com.puppycrawl.tools</groupId> + <artifactId>checkstyle</artifactId> + <version>6.19</version> + </dependency> + </dependencies> + <configuration> + <configLocation>/tools/maven/strict-checkstyle.xml</configLocation> + <suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation> + <includeTestSourceDirectory>true</includeTestSourceDirectory> + <logViolationsToConsole>true</logViolationsToConsole> + <failOnViolation>true</failOnViolation> + </configuration> + <executions> + <!-- + Execute checkstyle after compilation but before tests. + + This ensures that any parsing or type checking errors are from + javac, so they look as expected. Beyond that, we want to + fail as early as possible. + --> + <execution> + <phase>test-compile</phase> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> + </build> + </project>
