[FLINK-6852] Fix misuse of GCD This closes #4077.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/825721e6 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/825721e6 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/825721e6 Branch: refs/heads/master Commit: 825721e6f1d8e34234f59d6ffde94af376146956 Parents: e13a7f8 Author: cactuslrd.lird <[email protected]> Authored: Tue Jun 6 12:23:25 2017 +0800 Committer: zentol <[email protected]> Committed: Wed Jun 7 23:06:08 2017 +0200 ---------------------------------------------------------------------- .../apache/flink/table/runtime/aggregate/AggregateUtil.scala | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/825721e6/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala ---------------------------------------------------------------------- diff --git a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala index ccfab00..04c5070 100644 --- a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala +++ b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala @@ -1501,13 +1501,7 @@ object AggregateUtil { case _ => throw new IllegalArgumentException() } - private[flink] def determineLargestTumblingSize(size: Long, slide: Long): Long = { - if (slide > size) { - gcd(slide, size) - } else { - gcd(size, slide) - } - } + private[flink] def determineLargestTumblingSize(size: Long, slide: Long) = gcd(size, slide) private def gcd(a: Long, b: Long): Long = { if (b == 0) a else gcd(b, a % b)
