Repository: flink
Updated Branches:
  refs/heads/release-1.4 a057cbf65 -> 602b0cabc


[FLINK-9210][metrics] Only call Gauge#getValue once during serialization


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/602b0cab
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/602b0cab
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/602b0cab

Branch: refs/heads/release-1.4
Commit: 602b0cabc4dbbd7d30f0783cbc47ca174b871e5e
Parents: a057cbf
Author: zentol <ches...@apache.org>
Authored: Wed Apr 18 18:16:41 2018 +0200
Committer: zentol <ches...@apache.org>
Committed: Wed Apr 18 18:18:22 2018 +0200

----------------------------------------------------------------------
 .../apache/flink/runtime/metrics/dump/MetricDumpSerialization.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/602b0cab/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
----------------------------------------------------------------------
diff --git 
a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
 
b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
index d821e0f..16a885d 100644
--- 
a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
+++ 
b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
@@ -220,7 +220,7 @@ public class MetricDumpSerialization {
                if (value == null) {
                        throw new NullPointerException("Value returned by gauge 
" + name + " was null.");
                }
-               String stringValue = gauge.getValue().toString();
+               String stringValue = value.toString();
                if (stringValue == null) {
                        throw new NullPointerException("toString() of the value 
returned by gauge " + name + " returned null.");
                }

Reply via email to