Repository: flink Updated Branches: refs/heads/release-1.6 b6fb4f636 -> 0da30b713
[FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource This closes #6374. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/1dd68354 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/1dd68354 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/1dd68354 Branch: refs/heads/release-1.6 Commit: 1dd683544e29004e28b53aa2856d6449ec58142c Parents: b6fb4f6 Author: zentol <ches...@apache.org> Authored: Thu Jul 19 13:47:53 2018 +0200 Committer: zentol <ches...@apache.org> Committed: Mon Jul 23 09:12:43 2018 +0200 ---------------------------------------------------------------------- .../runtime/io/network/netty/NettyLeakDetectionResource.java | 8 ++++++++ 1 file changed, 8 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/1dd68354/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java index 027f454..1dbeb25 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java @@ -21,7 +21,9 @@ package org.apache.flink.runtime.io.network.netty; import org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector; import org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetectorFactory; +import org.junit.Assert; import org.junit.rules.ExternalResource; +import org.slf4j.LoggerFactory; import javax.annotation.concurrent.GuardedBy; @@ -48,6 +50,12 @@ public class NettyLeakDetectionResource extends ExternalResource { private static final Object refCountLock = new Object(); private static int refCount = 0; + public NettyLeakDetectionResource() { + Assert.assertTrue( + "Error logging must be enabled for the ResourceLeakDetector.", + LoggerFactory.getLogger(ResourceLeakDetector.class).isErrorEnabled()); + } + @Override protected void before() { synchronized (refCountLock) {
