[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
This closes #6373. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/e8b70cc2 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/e8b70cc2 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/e8b70cc2 Branch: refs/heads/release-1.5 Commit: e8b70cc2bc47ad6aa52104814e28d6e35e7f8eb9 Parents: 3041bd3 Author: Till Rohrmann <trohrm...@apache.org> Authored: Thu Jul 19 13:07:44 2018 +0200 Committer: Till Rohrmann <trohrm...@apache.org> Committed: Mon Jul 23 17:22:52 2018 +0200 ---------------------------------------------------------------------- .../org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java | 4 ++-- .../apache/flink/runtime/resourcemanager/ResourceManager.java | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/e8b70cc2/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java index 27440a3..829c82e 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java @@ -1011,7 +1011,7 @@ public class SlotPool extends RpcEndpoint implements SlotPoolGateway, AllocatedS failPendingRequest(pendingRequest, cause); } else if (availableSlots.tryRemove(allocationID)) { - log.debug("Failed available slot [{}] with ", allocationID, cause); + log.debug("Failed available slot with allocation id {}.", allocationID, cause); } else { AllocatedSlot allocatedSlot = allocatedSlots.remove(allocationID); @@ -1021,7 +1021,7 @@ public class SlotPool extends RpcEndpoint implements SlotPoolGateway, AllocatedS allocatedSlot.releasePayload(cause); } else { - log.trace("Outdated request to fail slot [{}] with ", allocationID, cause); + log.trace("Outdated request to fail slot with allocation id {}.", allocationID, cause); } } // TODO: add some unit tests when the previous two are ready, the allocation may failed at any phase http://git-wip-us.apache.org/repos/asf/flink/blob/e8b70cc2/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java index 6b104ed..fb1b888 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java @@ -1012,7 +1012,6 @@ public abstract class ResourceManager<WorkerType extends ResourceIDRetrievable> @Override public void notifyAllocationFailure(JobID jobId, AllocationID allocationId, Exception cause) { validateRunsInMainThread(); - log.info("Slot request with allocation id {} for job {} failed.", allocationId, jobId, cause); JobManagerRegistration jobManagerRegistration = jobManagerRegistrations.get(jobId); if (jobManagerRegistration != null) {
