[flink] branch master updated: [FLINK-9443][streaming] Remove unused parameter in StreamGraphHasherV2#generateNodeLocalHash

[chesnay]

This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 5e73062  [FLINK-9443][streaming] Remove unused parameter in 
StreamGraphHasherV2#generateNodeLocalHash
5e73062 is described below

commit 5e73062cc980e172a84821085a75d520f4fb2a65
Author: Aitozi <1059789...@qq.com>
AuthorDate: Wed Oct 17 03:57:57 2018 +0800

    [FLINK-9443][streaming] Remove unused parameter in 
StreamGraphHasherV2#generateNodeLocalHash
---
 .../flink/streaming/api/graph/StreamGraphHasherV2.java     | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphHasherV2.java
 
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphHasherV2.java
index 9bbcec0..d7c51bc 100644
--- 
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphHasherV2.java
+++ 
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphHasherV2.java
@@ -67,7 +67,7 @@ public class StreamGraphHasherV2 implements StreamGraphHasher 
{
         *
         * <p>The generated hash is deterministic with respect to:
         * <ul>
-        *   <li>node-local properties (like parallelism, UDF, node ID),
+        *   <li>node-local properties (node ID),
         *   <li>chained output nodes, and
         *   <li>input nodes hashes
         * </ul>
@@ -216,16 +216,15 @@ public class StreamGraphHasherV2 implements 
StreamGraphHasher {
                // hashes as the ID. We cannot use the node's ID, because it is
                // assigned from a static counter. This will result in two 
identical
                // programs having different hashes.
-               generateNodeLocalHash(node, hasher, hashes.size());
+               generateNodeLocalHash(hasher, hashes.size());
 
                // Include chained nodes to hash
                for (StreamEdge outEdge : node.getOutEdges()) {
                        if (isChainable(outEdge, isChainingEnabled)) {
-                               StreamNode chainedNode = 
outEdge.getTargetVertex();
 
                                // Use the hash size again, because the nodes 
are chained to
                                // this node. This does not add a hash for the 
chained nodes.
-                               generateNodeLocalHash(chainedNode, hasher, 
hashes.size());
+                               generateNodeLocalHash(hasher, hashes.size());
                        }
                }
 
@@ -265,15 +264,14 @@ public class StreamGraphHasherV2 implements 
StreamGraphHasher {
        }
 
        /**
-        * Applies the {@link Hasher} to the {@link StreamNode} (only node local
-        * attributes are taken into account). The hasher encapsulates the 
current
-        * state of the hash.
+        * Applies the {@link Hasher} to the {@link StreamNode} . The hasher 
encapsulates
+        * the current state of the hash.
         *
         * <p>The specified ID is local to this node. We cannot use the
         * {@link StreamNode#id}, because it is incremented in a static counter.
         * Therefore, the IDs for identical jobs will otherwise be different.
         */
-       private void generateNodeLocalHash(StreamNode node, Hasher hasher, int 
id) {
+       private void generateNodeLocalHash(Hasher hasher, int id) {
                // This resolves conflicts for otherwise identical source 
nodes. BUT
                // the generated hash codes depend on the ordering of the nodes 
in the
                // stream graph.