This is an automated email from the ASF dual-hosted git repository.

trohrmann pushed a commit to branch release-1.6
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.6 by this push:
     new 36bb0f4  [FLINK-10906][docker] Don't print configuration in 
docker-entrypoint.sh
36bb0f4 is described below

commit 36bb0f4a4d464ee46c7246803dee9a38c133ee59
Author: Till Rohrmann <trohrm...@apache.org>
AuthorDate: Fri Nov 16 16:38:55 2018 +0100

    [FLINK-10906][docker] Don't print configuration in docker-entrypoint.sh
    
    In order to not leak secrets we should not print the configuration in 
docker-entrypoint.sh.
---
 flink-container/docker/docker-entrypoint.sh     | 1 -
 flink-contrib/docker-flink/docker-entrypoint.sh | 2 --
 2 files changed, 3 deletions(-)

diff --git a/flink-container/docker/docker-entrypoint.sh 
b/flink-container/docker/docker-entrypoint.sh
index 85ba866..0bf7c04 100755
--- a/flink-container/docker/docker-entrypoint.sh
+++ b/flink-container/docker/docker-entrypoint.sh
@@ -32,7 +32,6 @@ if [ "${CMD}" == "--help" -o "${CMD}" == "-h" ]; then
     exit 0
 elif [ "${CMD}" == "${JOB_CLUSTER}" -o "${CMD}" == "${TASK_MANAGER}" ]; then
     echo "Starting the ${CMD}"
-    echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
 
     if [ "${CMD}" == "${TASK_MANAGER}" ]; then
         exec $FLINK_HOME/bin/taskmanager.sh start-foreground "$@"
diff --git a/flink-contrib/docker-flink/docker-entrypoint.sh 
b/flink-contrib/docker-flink/docker-entrypoint.sh
index 1edf99c..a4e279f 100755
--- a/flink-contrib/docker-flink/docker-entrypoint.sh
+++ b/flink-contrib/docker-flink/docker-entrypoint.sh
@@ -29,7 +29,6 @@ elif [ "$1" == "jobmanager" ]; then
     echo "Starting Job Manager"
     sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: 
${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml
 
-    echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
     exec $FLINK_HOME/bin/jobmanager.sh start-foreground
 elif [ "$1" == "taskmanager" ]; then
 
@@ -37,7 +36,6 @@ elif [ "$1" == "taskmanager" ]; then
     sed -i -e "s/taskmanager.numberOfTaskSlots: 
1/taskmanager.numberOfTaskSlots: $(grep -c ^processor /proc/cpuinfo)/g" 
$FLINK_HOME/conf/flink-conf.yaml
 
     echo "Starting Task Manager"
-    echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
     exec $FLINK_HOME/bin/taskmanager.sh start-foreground
 fi
 

Reply via email to