This is an automated email from the ASF dual-hosted git repository.

kkloudas pushed a commit to branch release-1.8
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.8 by this push:
     new abf2a85  [FLINK-11185] Fix StreamSourceOperatorWatermarksTest 
instability.
abf2a85 is described below

commit abf2a85ac7a3057035348c02b17fe254ce6245b7
Author: Kostas Kloudas <kklou...@gmail.com>
AuthorDate: Tue Feb 26 16:53:14 2019 +0100

    [FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.
    
    The cause of the instability seems to be that due to a not-so-rare timing,
    the thread that calls the `interrupt()` on the main thread, runs still
    after its original test finishes and calls `interrupt()` during execution
    of the next test. This causes the normal execution (or `sleep()` in this 
case)
    to be interrupted.
---
 .../streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java | 2 --
 1 file changed, 2 deletions(-)

diff --git 
a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
 
b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
index 6d2b310..495df42 100644
--- 
a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
+++ 
b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
@@ -97,7 +97,6 @@ public class StreamSourceOperatorWatermarksTest {
        public void testNoMaxWatermarkOnAsyncCancel() throws Exception {
 
                final List<StreamElement> output = new ArrayList<>();
-               final Thread runner = Thread.currentThread();
 
                // regular stream source operator
                final StreamSource<String, InfiniteSource<String>> operator =
@@ -113,7 +112,6 @@ public class StreamSourceOperatorWatermarksTest {
                                        Thread.sleep(200);
                                } catch (InterruptedException ignored) {}
                                operator.cancel();
-                               runner.interrupt();
                        }
                }.start();
 

Reply via email to