This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 654e718 [hotfix] Fix checkstyle violations in CheckpointCoordinator
654e718 is described below
commit 654e71832bff644eeb9433671015b99394e8105e
Author: Till Rohrmann <[email protected]>
AuthorDate: Wed Feb 27 13:23:39 2019 +0100
[hotfix] Fix checkstyle violations in CheckpointCoordinator
---
.../runtime/checkpoint/CheckpointCoordinator.java | 44 +++++++++++-----------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
index 3890f79..9935455 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
@@ -77,12 +77,12 @@ public class CheckpointCoordinator {
private static final Logger LOG =
LoggerFactory.getLogger(CheckpointCoordinator.class);
- /** The number of recent checkpoints whose IDs are remembered */
+ /** The number of recent checkpoints whose IDs are remembered. */
private static final int NUM_GHOST_CHECKPOINT_IDS = 16;
//
------------------------------------------------------------------------
- /** Coordinator-wide lock to safeguard the checkpoint updates */
+ /** Coordinator-wide lock to safeguard the checkpoint updates. */
private final Object lock = new Object();
/** Lock specially to make sure that trigger requests do not overtake
each other.
@@ -92,25 +92,25 @@ public class CheckpointCoordinator {
* messages during that phase. */
private final Object triggerLock = new Object();
- /** The job whose checkpoint this coordinator coordinates */
+ /** The job whose checkpoint this coordinator coordinates. */
private final JobID job;
- /** Default checkpoint properties **/
+ /** Default checkpoint properties. **/
private final CheckpointProperties checkpointProperties;
- /** The executor used for asynchronous calls, like potentially blocking
I/O */
+ /** The executor used for asynchronous calls, like potentially blocking
I/O. */
private final Executor executor;
- /** Tasks who need to be sent a message when a checkpoint is started */
+ /** Tasks who need to be sent a message when a checkpoint is started. */
private final ExecutionVertex[] tasksToTrigger;
- /** Tasks who need to acknowledge a checkpoint before it succeeds */
+ /** Tasks who need to acknowledge a checkpoint before it succeeds. */
private final ExecutionVertex[] tasksToWaitFor;
- /** Tasks who need to be sent a message when a checkpoint is confirmed
*/
+ /** Tasks who need to be sent a message when a checkpoint is confirmed.
*/
private final ExecutionVertex[] tasksToCommitTo;
- /** Map from checkpoint ID to the pending checkpoint */
+ /** Map from checkpoint ID to the pending checkpoint. */
private final Map<Long, PendingCheckpoint> pendingCheckpoints;
/** Completed checkpoints. Implementations can be blocking. Make sure
calls to methods
@@ -118,10 +118,10 @@ public class CheckpointCoordinator {
private final CompletedCheckpointStore completedCheckpointStore;
/** The root checkpoint state backend, which is responsible for
initializing the
- * checkpoint, storing the metadata, and cleaning up the checkpoint */
+ * checkpoint, storing the metadata, and cleaning up the checkpoint. */
private final CheckpointStorage checkpointStorage;
- /** A list of recent checkpoint IDs, to identify late messages (vs
invalid ones) */
+ /** A list of recent checkpoint IDs, to identify late messages (vs
invalid ones). */
private final ArrayDeque<Long> recentPendingCheckpoints;
/** Checkpoint ID counter to ensure ascending IDs. In case of job
manager failures, these
@@ -132,32 +132,32 @@ public class CheckpointCoordinator {
* max concurrent checkpoints and minimum-pause values */
private final long baseInterval;
- /** The max time (in ms) that a checkpoint may take */
+ /** The max time (in ms) that a checkpoint may take. */
private final long checkpointTimeout;
/** The min time(in ns) to delay after a checkpoint could be triggered.
Allows to
* enforce minimum processing time between checkpoint attempts */
private final long minPauseBetweenCheckpointsNanos;
- /** The maximum number of checkpoints that may be in progress at the
same time */
+ /** The maximum number of checkpoints that may be in progress at the
same time. */
private final int maxConcurrentCheckpointAttempts;
- /** The timer that handles the checkpoint timeouts and triggers
periodic checkpoints */
+ /** The timer that handles the checkpoint timeouts and triggers
periodic checkpoints. */
private final ScheduledThreadPoolExecutor timer;
- /** The master checkpoint hooks executed by this checkpoint coordinator
*/
+ /** The master checkpoint hooks executed by this checkpoint
coordinator. */
private final HashMap<String, MasterTriggerRestoreHook<?>> masterHooks;
- /** Actor that receives status updates from the execution graph this
coordinator works for */
+ /** Actor that receives status updates from the execution graph this
coordinator works for. */
private JobStatusListener jobStatusListener;
- /** The number of consecutive failed trigger attempts */
+ /** The number of consecutive failed trigger attempts. */
private final AtomicInteger numUnsuccessfulCheckpointsTriggers = new
AtomicInteger(0);
- /** A handle to the current periodic trigger, to cancel it when
necessary */
+ /** A handle to the current periodic trigger, to cancel it when
necessary. */
private ScheduledFuture<?> currentPeriodicTrigger;
- /** The timestamp (via {@link System#nanoTime()}) when the last
checkpoint completed */
+ /** The timestamp (via {@link System#nanoTime()}) when the last
checkpoint completed. */
private long lastCheckpointCompletionNanos;
/** Flag whether a triggered checkpoint should immediately schedule the
next checkpoint.
@@ -168,17 +168,17 @@ public class CheckpointCoordinator {
* accessed in synchronized scope */
private boolean triggerRequestQueued;
- /** Flag marking the coordinator as shut down (not accepting any
messages any more) */
+ /** Flag marking the coordinator as shut down (not accepting any
messages any more). */
private volatile boolean shutdown;
/** Optional tracker for checkpoint statistics. */
@Nullable
private CheckpointStatsTracker statsTracker;
- /** A factory for SharedStateRegistry objects */
+ /** A factory for SharedStateRegistry objects. */
private final SharedStateRegistryFactory sharedStateRegistryFactory;
- /** Registry that tracks state which is shared across (incremental)
checkpoints */
+ /** Registry that tracks state which is shared across (incremental)
checkpoints. */
private SharedStateRegistry sharedStateRegistry;
//
--------------------------------------------------------------------------------------------
