This is an automated email from the ASF dual-hosted git repository. chesnay pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit b32e1f611d831c4bed695c28a2880fb42c58ac28 Author: Andrey Zagrebin <[email protected]> AuthorDate: Wed Jun 26 10:02:55 2019 +0200 [hotfix][tests] ResultPartitionDeploymentDescriptorTest cleanup and test serialization of UnknownShuffleDescriptor without ResultPartitionDeploymentDescriptor --- .../deployment/ResultPartitionDeploymentDescriptorTest.java | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java index c5de724..90301fc 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java @@ -27,6 +27,7 @@ import org.apache.flink.runtime.io.network.partition.ResultPartitionType; import org.apache.flink.runtime.jobgraph.IntermediateDataSetID; import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID; import org.apache.flink.runtime.shuffle.NettyShuffleDescriptor; +import org.apache.flink.runtime.shuffle.NettyShuffleDescriptor.NetworkPartitionConnectionInfo; import org.apache.flink.runtime.shuffle.PartitionDescriptor; import org.apache.flink.runtime.shuffle.ShuffleDescriptor; import org.apache.flink.runtime.shuffle.UnknownShuffleDescriptor; @@ -72,13 +73,9 @@ public class ResultPartitionDeploymentDescriptorTest extends TestLogger { * Tests simple de/serialization with {@link UnknownShuffleDescriptor}. */ @Test - public void testSerializationWithUnknownShuffleDescriptor() throws Exception { + public void testSerializationOfUnknownShuffleDescriptor() throws IOException { ShuffleDescriptor shuffleDescriptor = new UnknownShuffleDescriptor(resultPartitionID); - - ResultPartitionDeploymentDescriptor copy = - createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor); - - ShuffleDescriptor shuffleDescriptorCopy = copy.getShuffleDescriptor(); + ShuffleDescriptor shuffleDescriptorCopy = CommonTestUtils.createCopySerializable(shuffleDescriptor); assertThat(shuffleDescriptorCopy, instanceOf(UnknownShuffleDescriptor.class)); assertThat(shuffleDescriptorCopy.getResultPartitionID(), is(resultPartitionID)); assertThat(shuffleDescriptorCopy.isUnknown(), is(true)); @@ -88,10 +85,10 @@ public class ResultPartitionDeploymentDescriptorTest extends TestLogger { * Tests simple de/serialization with {@link NettyShuffleDescriptor}. */ @Test - public void testSerializationWithNettyShuffleDescriptor() throws Exception { + public void testSerializationWithNettyShuffleDescriptor() throws IOException { ShuffleDescriptor shuffleDescriptor = new NettyShuffleDescriptor( producerLocation, - new NettyShuffleDescriptor.NetworkPartitionConnectionInfo(connectionID), + new NetworkPartitionConnectionInfo(connectionID), resultPartitionID); ResultPartitionDeploymentDescriptor copy =
