This is an automated email from the ASF dual-hosted git repository. twalthr pushed a commit to branch release-1.9 in repository https://gitbox.apache.org/repos/asf/flink.git
commit 5eda255740b7b5f8f0033ab5e57e7b2b20c909be Author: godfreyhe <[email protected]> AuthorDate: Fri Jul 19 16:01:57 2019 +0800 [FLINK-13266][table-common] Improve comment for FilterableTableTableSource Flink planner planner will push down PlannerExpressions (which are defined in flink-table-planner module), while Blink planner will push down Expressions. So the implementation for Flink planner and Blink planner should be different and incompatible. --- .../java/org/apache/flink/table/sources/FilterableTableSource.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java index fc144d5..a602ef7 100644 --- a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java +++ b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java @@ -33,6 +33,11 @@ public interface FilterableTableSource<T> { * have been translated in conjunctive form, and table source can only pick those predicates * that it supports. * + * <p><strong>WARNING:</strong> Flink planner will push down PlannerExpressions + * (which are defined in flink-table-planner module), while Blink planner will push down {@link Expression}s. + * So the implementation for Flink planner and Blink planner should be different and incompatible. + * PlannerExpression will be removed in the future. + * * <p>After trying to push predicates down, we should return a new {@link TableSource} * instance which holds all pushed down predicates. Even if we actually pushed nothing down, * it is recommended that we still return a new {@link TableSource} instance since we will
