This is an automated email from the ASF dual-hosted git repository.
trohrmann pushed a commit to branch release-1.12
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.12 by this push:
new c35cdbc [FLINK-19369][tests] Disable
BlobClientSslTest.testGetFailsDuringStreaming*
c35cdbc is described below
commit c35cdbc1e31573b664e6343bb29df98970dd92c1
Author: Till Rohrmann <[email protected]>
AuthorDate: Fri Dec 18 12:16:00 2020 +0100
[FLINK-19369][tests] Disable BlobClientSslTest.testGetFailsDuringStreaming*
The test cases
BlobClientSslTest.testGetFailsDuringStreamingForJobPermanentBlob,
.testGetFailsDuringStreamingNoJobTransientBlob and
.testgetFailsDuringStreamingForJobTransientBlob
can deadlock when being used with SSL enabled because an SSL stream can
deadlock when
not being consumed and closed at the same time.
This closes #14424.
---
.../test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java | 5 +++++
.../test/java/org/apache/flink/runtime/blob/BlobClientTest.java | 7 +++++++
2 files changed, 12 insertions(+)
diff --git
a/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
index f4b9251..f7c381c 100644
---
a/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
+++
b/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
@@ -92,6 +92,11 @@ public class BlobClientSslTest extends BlobClientTest {
}
}
+ @Override
+ protected boolean isSSLEnabled() {
+ return true;
+ }
+
protected Configuration getBlobClientConfig() {
return sslClientConfig;
}
diff --git
a/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
index a37a356..348266a 100644
---
a/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
+++
b/flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
@@ -56,6 +56,7 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeFalse;
/**
* This class contains unit tests for the {@link BlobClient}.
@@ -233,6 +234,10 @@ public class BlobClientTest extends TestLogger {
validateGetAndClose(actualInputStream, new
FileInputStream(expectedFile));
}
+ protected boolean isSSLEnabled() {
+ return false;
+ }
+
@Test
public void testContentAddressableBufferTransientBlob() throws
IOException, InterruptedException {
testContentAddressableBuffer(TRANSIENT_BLOB);
@@ -420,6 +425,8 @@ public class BlobClientTest extends TestLogger {
private void testGetFailsDuringStreaming(@Nullable final JobID jobId,
BlobKey.BlobType blobType)
throws IOException {
+ assumeFalse("This test can deadlock when using SSL. See
FLINK-19369.", isSSLEnabled());
+
try (BlobClient client = new BlobClient(
new InetSocketAddress("localhost",
getBlobServer().getPort()), getBlobClientConfig())) {
