This is an automated email from the ASF dual-hosted git repository.
dwysakowicz pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/flink-web.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 9782d3f Rebuild page
9782d3f is described below
commit 9782d3f72eefaebfdd9aa88c11713c1c96900ab8
Author: Dawid Wysakowicz <[email protected]>
AuthorDate: Wed May 5 09:25:33 2021 +0200
Rebuild page
---
content/contributing/code-style-and-quality-common.html | 12 ++++++++++++
content/zh/contributing/code-style-and-quality-common.html | 12 ++++++++++++
2 files changed, 24 insertions(+)
diff --git a/content/contributing/code-style-and-quality-common.html
b/content/contributing/code-style-and-quality-common.html
index d76a08d..728a63c 100644
--- a/content/contributing/code-style-and-quality-common.html
+++ b/content/contributing/code-style-and-quality-common.html
@@ -530,6 +530,18 @@ then the S3 access should be factored out into an
interface and test should repl
</li>
</ul>
+<p><strong>Avoid timeouts in JUnit tests</strong></p>
+
+<p>Generally speaking, we should avoid setting local timeouts in JUnit tests
but rather depend on the
+global timeout in Azure. The global timeout benefits from taking thread dumps
just before timing out
+the build, easing debugging.</p>
+
+<p>At the same time, any timeout value that you manually set is arbitrary. If
it’s set too low, you get
+test instabilities. What too low means depends on numerous factors, such as
hardware and current
+utilization (especially I/O). Moreover, a local timeout is more
maintenance-intensive. It’s one more
+knob where you can tweak a build. If you change the test a bit, you also need
to double-check the
+timeout. Hence, there have been quite a few commits that just increase
timeouts.</p>
+
<h3 id="performance-awareness">Performance Awareness</h3>
<p>We can conceptually distinguish between code that “coordinates” and code
that “processes data”. Code that coordinates should always favor simplicity and
cleanness. Data processing code is highly performance critical and should
optimize for performance.</p>
diff --git a/content/zh/contributing/code-style-and-quality-common.html
b/content/zh/contributing/code-style-and-quality-common.html
index c1893e3..5d09b5e 100644
--- a/content/zh/contributing/code-style-and-quality-common.html
+++ b/content/zh/contributing/code-style-and-quality-common.html
@@ -528,6 +528,18 @@ then the S3 access should be factored out into an
interface and test should repl
</li>
</ul>
+<p><strong>Avoid timeouts in JUnit tests</strong></p>
+
+<p>Generally speaking, we should avoid setting local timeouts in JUnit tests
but rather depend on the
+global timeout in Azure. The global timeout benefits from taking thread dumps
just before timing out
+the build, easing debugging.</p>
+
+<p>At the same time, any timeout value that you manually set is arbitrary. If
it’s set too low, you get
+test instabilities. What too low means depends on numerous factors, such as
hardware and current
+utilization (especially I/O). Moreover, a local timeout is more
maintenance-intensive. It’s one more
+knob where you can tweak a build. If you change the test a bit, you also need
to double-check the
+timeout. Hence, there have been quite a few commits that just increase
timeouts.</p>
+
<h3 id="performance-awareness">Performance Awareness</h3>
<p>We can conceptually distinguish between code that “coordinates” and code
that “processes data”. Code that coordinates should always favor simplicity and
cleanness. Data processing code is highly performance critical and should
optimize for performance.</p>
