This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch 23383
in repository https://gitbox.apache.org/repos/asf/flink-benchmarks.git

commit 3a3d25d727e1be736ab513e4ce9ea9f6dd75e9db
Author: Chesnay Schepler <[email protected]>
AuthorDate: Wed Jul 14 14:48:59 2021 +0200

    [FLINK-23383] Prevent duplicate setUp/tearDown calls
---
 .../java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java | 1 -
 .../flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java    | 1 -
 .../org/apache/flink/benchmark/MemoryStateBackendBenchmark.java     | 6 ------
 .../java/org/apache/flink/benchmark/RocksStateBackendBenchmark.java | 6 ------
 .../apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java    | 1 -
 src/main/java/org/apache/flink/benchmark/WindowBenchmarks.java      | 1 -
 6 files changed, 16 deletions(-)

diff --git 
a/src/main/java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java 
b/src/main/java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java
index 598c8aa..f8f2a20 100644
--- a/src/main/java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java
+++ b/src/main/java/org/apache/flink/benchmark/BlockingPartitionBenchmark.java
@@ -87,7 +87,6 @@ public class BlockingPartitionBenchmark extends BenchmarkBase 
{
                 */
                private final int parallelism = 4;
 
-               @Setup
                public void setUp() throws IOException {
                        super.setUp();
 
diff --git 
a/src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java
 
b/src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java
index b8b9572..155bba6 100644
--- 
a/src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java
+++ 
b/src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java
@@ -66,7 +66,6 @@ public class BlockingPartitionRemoteChannelBenchmark extends 
RemoteBenchmarkBase
      */
     public static class BlockingPartitionEnvironmentContext extends 
FlinkEnvironmentContext {
 
-        @Setup
         public void setUp() throws IOException {
             super.setUp();
 
diff --git 
a/src/main/java/org/apache/flink/benchmark/MemoryStateBackendBenchmark.java 
b/src/main/java/org/apache/flink/benchmark/MemoryStateBackendBenchmark.java
index 09c0095..ea0e779 100644
--- a/src/main/java/org/apache/flink/benchmark/MemoryStateBackendBenchmark.java
+++ b/src/main/java/org/apache/flink/benchmark/MemoryStateBackendBenchmark.java
@@ -63,14 +63,8 @@ public class MemoryStateBackendBenchmark extends 
StateBackendBenchmarkBase {
                @Param({"MEMORY", "FS", "FS_ASYNC"})
                public StateBackend stateBackend = StateBackend.MEMORY;
 
-               @Setup
                public void setUp() throws IOException {
                        super.setUp(stateBackend, RECORDS_PER_INVOCATION);
                }
-
-               @TearDown
-               public void tearDown() throws IOException {
-                       super.tearDown();
-               }
        }
 }
diff --git 
a/src/main/java/org/apache/flink/benchmark/RocksStateBackendBenchmark.java 
b/src/main/java/org/apache/flink/benchmark/RocksStateBackendBenchmark.java
index 4dc4421..5c6af97 100644
--- a/src/main/java/org/apache/flink/benchmark/RocksStateBackendBenchmark.java
+++ b/src/main/java/org/apache/flink/benchmark/RocksStateBackendBenchmark.java
@@ -66,16 +66,10 @@ public class RocksStateBackendBenchmark extends 
StateBackendBenchmarkBase {
                @Param({"ROCKS", "ROCKS_INC"})
                public StateBackend stateBackend = StateBackend.MEMORY;
 
-               @Setup
                public void setUp() throws IOException {
                        super.setUp(stateBackend, RECORDS_PER_INVOCATION);
                }
 
-               @TearDown
-               public void tearDown() throws IOException {
-                       super.tearDown();
-               }
-
                @Override
                protected Configuration createConfiguration() {
                        Configuration configuration = 
super.createConfiguration();
diff --git 
a/src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
 
b/src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
index 093ad53..b371563 100644
--- 
a/src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
+++ 
b/src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
@@ -94,7 +94,6 @@ public class UnalignedCheckpointTimeBenchmark extends 
BenchmarkBase {
         @Param({"0", "1", "ALIGNED"})
         public String timeout = "0";
 
-        @Setup
         public void setUp() throws IOException {
             super.setUp();
 
diff --git a/src/main/java/org/apache/flink/benchmark/WindowBenchmarks.java 
b/src/main/java/org/apache/flink/benchmark/WindowBenchmarks.java
index 6489fce..8fa6b6b 100644
--- a/src/main/java/org/apache/flink/benchmark/WindowBenchmarks.java
+++ b/src/main/java/org/apache/flink/benchmark/WindowBenchmarks.java
@@ -83,7 +83,6 @@ public class WindowBenchmarks extends BenchmarkBase {
 
                public DataStreamSource<IntegerLongSource.Record> source;
 
-               @Setup
                @Override
                public void setUp() throws IOException {
                        super.setUp();

Reply via email to