This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 4a91354 [FLINK-25064][rest] Remove incorrect @VisibleForTesting
4a91354 is described below
commit 4a91354147c8cea8fc71d8939b8feb21934e7c5d
Author: Chesnay Schepler <[email protected]>
AuthorDate: Thu Nov 25 16:08:57 2021 +0100
[FLINK-25064][rest] Remove incorrect @VisibleForTesting
---
.../violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5 | 2 --
.../src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java | 1 -
2 files changed, 3 deletions(-)
diff --git
a/flink-architecture-tests/violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5
b/flink-architecture-tests/violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5
index a681331..f5e3ff0 100644
--- a/flink-architecture-tests/violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5
+++ b/flink-architecture-tests/violations/e5126cae-f3fe-48aa-b6fb-60ae6cc3fcd5
@@ -29,8 +29,6 @@ Method
<org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChanne
Method
<org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.getNumberOfRequiredBuffers()>
calls method
<org.apache.flink.runtime.io.network.partition.consumer.BufferManager.unsynchronizedGetNumberOfRequiredBuffers()>
in (RemoteInputChannel.java:341)
Method
<org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.isWaitingForFloatingBuffers()>
calls method
<org.apache.flink.runtime.io.network.partition.consumer.BufferManager.unsynchronizedIsWaitingForFloatingBuffers()>
in (RemoteInputChannel.java:351)
Method
<org.apache.flink.runtime.operators.coordination.RecreateOnResetOperatorCoordinator$DeferrableCoordinator.closeAsync(long)>
calls method
<org.apache.flink.runtime.operators.coordination.RecreateOnResetOperatorCoordinator$QuiesceableContext.quiesce()>
in (RecreateOnResetOperatorCoordinator.java:319)
-Method
<org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext,
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpObject)> calls
method
<org.apache.flink.runtime.rest.RestServerEndpoint.createUploadDir(java.nio.file.Path,
org.slf4j.Logger, boolean)> in (FileUploadHandler.java:132)
-Method
<org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext,
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpObject)> calls
method
<org.apache.flink.runtime.rest.RestServerEndpoint.createUploadDir(java.nio.file.Path,
org.slf4j.Logger, boolean)> in (FileUploadHandler.java:147)
Method
<org.apache.flink.runtime.state.heap.HeapKeyedStateBackend.numKeyValueStateEntries(java.lang.Object)>
calls method
<org.apache.flink.runtime.state.heap.StateTable.sizeOfNamespace(java.lang.Object)>
in (HeapKeyedStateBackend.java:391)
Method
<org.apache.flink.runtime.state.heap.StateTable.sizeOfNamespace(java.lang.Object)>
calls method
<org.apache.flink.runtime.state.heap.StateMap.sizeOfNamespace(java.lang.Object)>
in (StateTable.java:361)
Method
<org.apache.flink.runtime.taskexecutor.TaskExecutor.registerNewJobAndCreateServices(org.apache.flink.api.common.JobID,
java.lang.String)> calls method
<org.apache.flink.runtime.taskexecutor.TaskExecutor$TaskExecutorJobServices.create(org.apache.flink.runtime.execution.librarycache.LibraryCacheManager$ClassLoaderLease,
java.lang.Runnable)> in (TaskExecutor.java:1121)
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
index cb07a32..cfadcd4 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
@@ -550,7 +550,6 @@ public abstract class RestServerEndpoint implements
AutoCloseableAsync {
}
/** Creates the upload dir if needed. */
- @VisibleForTesting
static void createUploadDir(
final Path uploadDir, final Logger log, final boolean
initialCreation)
throws IOException {
