This is an automated email from the ASF dual-hosted git repository.

tangyun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new d08a1d0  [FLINK-25094][test] Correct the 
LatencyTrackingMapStateTest#verifyIterator
d08a1d0 is described below

commit d08a1d0f4035485283f10611113d4d0fc0a8aaca
Author: Jinzhong Li <[email protected]>
AuthorDate: Wed Dec 15 12:24:10 2021 +0800

    [FLINK-25094][test] Correct the LatencyTrackingMapStateTest#verifyIterator
    
    This closes #18111.
---
 .../runtime/state/metrics/LatencyTrackingMapStateTest.java   | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git 
a/flink-runtime/src/test/java/org/apache/flink/runtime/state/metrics/LatencyTrackingMapStateTest.java
 
b/flink-runtime/src/test/java/org/apache/flink/runtime/state/metrics/LatencyTrackingMapStateTest.java
index e917c66..8debe9a 100644
--- 
a/flink-runtime/src/test/java/org/apache/flink/runtime/state/metrics/LatencyTrackingMapStateTest.java
+++ 
b/flink-runtime/src/test/java/org/apache/flink/runtime/state/metrics/LatencyTrackingMapStateTest.java
@@ -25,6 +25,7 @@ import org.apache.flink.api.common.typeutils.TypeSerializer;
 import org.apache.flink.api.common.typeutils.base.IntSerializer;
 import org.apache.flink.runtime.state.AbstractKeyedStateBackend;
 import org.apache.flink.runtime.state.VoidNamespace;
+import org.apache.flink.util.function.SupplierWithException;
 
 import org.junit.Test;
 
@@ -138,22 +139,22 @@ public class LatencyTrackingMapStateTest extends 
LatencyTrackingStateTestBase<In
             verifyIterator(
                     latencyTrackingState,
                     latencyTrackingStateMetric,
-                    latencyTrackingState.iterator(),
+                    latencyTrackingState::iterator,
                     true);
             verifyIterator(
                     latencyTrackingState,
                     latencyTrackingStateMetric,
-                    latencyTrackingState.entries().iterator(),
+                    () -> latencyTrackingState.entries().iterator(),
                     true);
             verifyIterator(
                     latencyTrackingState,
                     latencyTrackingStateMetric,
-                    latencyTrackingState.keys().iterator(),
+                    () -> latencyTrackingState.keys().iterator(),
                     false);
             verifyIterator(
                     latencyTrackingState,
                     latencyTrackingStateMetric,
-                    latencyTrackingState.values().iterator(),
+                    () -> latencyTrackingState.values().iterator(),
                     false);
         } finally {
             if (keyedBackend != null) {
@@ -166,7 +167,7 @@ public class LatencyTrackingMapStateTest extends 
LatencyTrackingStateTestBase<In
     private <E> void verifyIterator(
             LatencyTrackingMapState<Integer, VoidNamespace, Long, Double> 
latencyTrackingState,
             LatencyTrackingMapState.MapStateLatencyMetrics 
latencyTrackingStateMetric,
-            Iterator<E> iterator,
+            SupplierWithException<Iterator<E>, Exception> iteratorSupplier,
             boolean removeIterator)
             throws Exception {
         ThreadLocalRandom random = ThreadLocalRandom.current();
@@ -174,6 +175,7 @@ public class LatencyTrackingMapStateTest extends 
LatencyTrackingStateTestBase<In
             latencyTrackingState.put((long) index, random.nextDouble());
         }
         int count = 1;
+        Iterator<E> iterator = iteratorSupplier.get();
         while (iterator.hasNext()) {
             int expectedResult = count == SAMPLE_INTERVAL ? 0 : count;
             assertEquals(expectedResult, 
latencyTrackingStateMetric.getIteratorHasNextCount());

Reply via email to