gyfora commented on pull request #1:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/1#issuecomment-1040066056


   @wangyang0918 thanks for the review and the comments:
   
   1. It seems that the operator sdk itself requires minimum java 11 and I dont 
immediately see a workaround to support java 8 with the current code. While 
originally we wanted to support java 8 to match Flink, I think if this becomes 
technically difficult I think we can live with java 11 as this would not affect 
Flink jobs deployed by the operator (they can still be java 8). So this only 
really affects the build env and container runtime. What do you think? cc 
@tweise 
   
   2. We should try to resolve this somehow, maybe by excluding the transitive 
fabric8 dep from `flink-kubernetes`, will take a look
   
   3. Right now the operator does not recover the flink job if something like 
this happens (as deleting the deployment is beyond the native integration) but 
we should defintely support this, I will file a jira for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to