Aitozi commented on a change in pull request #6:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/6#discussion_r809244913



##########
File path: Dockerfile
##########
@@ -17,8 +17,18 @@
 
################################################################################
 # Build
 FROM maven:3.8.4-openjdk-11 AS build
-WORKDIR /app
 
+WORKDIR /tmp/flink/plugins
+ENV FLINK_VERSION=1.14.3
+RUN --mount=type=cache,target=/root/.m2 \

Review comment:
       nit: Can we move the dependencies to the `pom.xml` to manage it with 
unified. By this, we can avoid to define `FLINK_VERSION` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to