bgeng777 edited a comment on pull request #9: URL: https://github.com/apache/flink-kubernetes-operator/pull/9#issuecomment-1046823084
Thanks a lot for the detailed review! 1. Sure. It seems that the fix of JM replicas is just a piece of codes so I did it here. I will move it out and leave the work to the dedicated [jira](https://issues.apache.org/jira/browse/FLINK-26216) for better tracking. 2. My bad. Check the `KUBERNETES_POD_TEMPLATE` field again and I understood it wrongly before. 3. Yes, I also think about using Builder pattern when refactoring. Considering not to change the code style too much, I did not use it initially. But I believe it could make codes more neat and flexible. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
