tweise commented on a change in pull request #10:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/10#discussion_r811538809
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java
##########
@@ -72,6 +72,12 @@ public static Configuration
getEffectiveConfig(FlinkDeployment flinkApp) {
KubernetesConfigOptions.ServiceExposedType.ClusterIP);
}
+ if (spec.getServiceAccount() != null) {
Review comment:
Thanks for catching the config parameter issue. Fix is pushed. This just
reinforces why we should not expose such implementation details to user (CR
should abstract how we interact with k8s and also work for standalone mode).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
