tweise commented on a change in pull request #13:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/13#discussion_r812557696
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -178,7 +150,14 @@ private void updateForReconciliationError(FlinkDeployment
flinkApp, String err)
@Override
public Optional<FlinkDeployment> updateErrorStatus(
FlinkDeployment flinkApp, RetryInfo retryInfo, RuntimeException e)
{
- LOG.warn("TODO: handle error status");
- return Optional.empty();
+ LOG.warn(
Review comment:
The log messages are as expected, but maybe we should also capture the
retry info in the status? And add an event when retries are exhausted?
Otherwise, that information is only transient in the operator SDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
