morhidi commented on a change in pull request #14:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/14#discussion_r812605055
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java
##########
@@ -41,5 +41,4 @@
private JobManagerSpec jobManager;
private TaskManagerSpec taskManager;
private JobSpec job;
- private Map<String, String> logging;
Review comment:
yes, also we discussed it with @gyfora that map is not the ideal form
here for the logging, we'll have to reintroduce it in another form to support
log4j, logback.. configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
