gyfora commented on a change in pull request #23:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/23#discussion_r814101642
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/JobStatus.java
##########
@@ -30,7 +32,7 @@
public class JobStatus {
private String jobName;
private String jobId;
- private String state;
Review comment:
Why are we renaming this and not other fields? I agree that it is not
super consistent we
jobName, jobId, state, updateTime, savepointLocation
Wouldnt it be better to have simply name, id, state ...
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/JobStatus.java
##########
@@ -30,7 +32,7 @@
public class JobStatus {
private String jobName;
private String jobId;
- private String state;
Review comment:
Maybe this could be a separate JIRA discussion to improve field naming
in the spec/status and do multiple changes together to simplify testing
(redeploying CRD etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
