Aitozi commented on a change in pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#discussion_r818188414
##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -46,6 +46,10 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag |
default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["/docker-entrypoint.sh", "operator"]
+ ports:
Review comment:
Do we have to expose port by default ? It's could be decided by a
variable like `--set metric.port=9999` ? If not present, we can skip to
declare, Right?
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/KubernetesOperatorMetricOptions.java
##########
@@ -23,8 +23,8 @@
/** Configuration options for metrics. */
public class KubernetesOperatorMetricOptions {
public static final ConfigOption<String> SCOPE_NAMING_KUBERNETES_OPERATOR =
- ConfigOptions.key("metrics.scope.kubernetes-operator")
-
.defaultValue("<host>.kubernetes-operator.<namespace>.<name>")
+ ConfigOptions.key("metrics.scope.kubernetes_operator")
Review comment:
nit: the underline format for flink option is not a common style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
