Aitozi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1058841888
> I'm ok with `k8soperator` :) . But I think the `PrometheusReporter` should
already handle the illegal metric name. I will take a closer look then.
@morhidi Sorry for bother you again, I have reproduced the error with group
name of `kubernetes-operator`. It is caused by not apply the `CharacterFilter`
from the reporter after I applied it to `KubernetesOperatorMetricGroup` It will
work with `PrometheusReporter`
```
@Override
protected final String getGroupName(CharacterFilter filter) {
return GROUP_NAME;
}
```
to
```
@Override
protected final String getGroupName(CharacterFilter filter) {
return filter.filterCharacters(GROUP_NAME);
}
```
It's ok with the current solution, just meant to make it clear :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
