mbalassi opened a new pull request #42:
URL: https://github.com/apache/flink-kubernetes-operator/pull/42


   This separates the Flink job role from the operator role, which fixes two 
issues:
   1. That when the `operatorNamespace` is the same as one of the 
`watchNamespaces` the install fails due to attempted duplicated role creation 
which I introduced in #35.
   2. That deleting the operator role affected jobs described in FLINK-26471.
   
   @wangyang0918 has raised another issue with #35 
[here](https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058750206),
 that prior to 1.15 when using `watchNamespaces` unless the user explicitly 
sets 
   ```
   kubernetes.rest-service.exposed.type: ClusterIP
   ```
   I would like to avoid overwriting the default Flink behavior in the 
operator, my suggestion is to present a warning to the user in the admission 
control validation and we might a line to the Readme / docs anyway.
   
   Also while testing this change I have discovered that the webhook fails when 
we have multiple entries in `watchNamespaces`. I will fix these two issues in a 
separate PR early next week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to